Skip to content

Conversation

@scopsy
Copy link
Contributor

@scopsy scopsy commented Jan 21, 2026

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit 144add8
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/697121a468e6610008763ec7

@github-actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: fix(worker): remove subscriber-cache header

Requirements:

  1. Follow the Conventional Commits specification
  2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Walkthrough

The change modifies the getSubscriberBySubscriberId method in the send-message use case. The CachedResponse decorator has been removed, and the method now calls subscriberRepository.findOne with an additional readPreference option set to 'secondaryPreferred'. The call signature has been adjusted with an additional parameter position. The data retrieval approach changes from utilizing caching to implementing direct database reads with secondary preference for read operations.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is a blank template with no actual content describing the changes, rationale, or context for the modification. Provide a detailed description explaining why the subscriber cache header was removed and what problem this fix addresses.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(worker): remove subscriber-cache header' directly relates to the main change in the changeset, which removes the CachedResponse decorator from a method call, effectively removing caching behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scopsy scopsy merged commit a451ade into next Jan 22, 2026
29 checks passed
@scopsy scopsy deleted the fix-caching-issue branch January 22, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants