Skip to content

Fix Windows test connection cleanup flakiness #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 2 commits into from
May 17, 2026
Merged

Fix Windows test connection cleanup flakiness #3837

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028d572
Fix test store connection cleanup
roji May 17, 2026
9962aef
Document disabled test SSL
roji May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:
run: dotnet test -c ${{ matrix.config }} --logger "GitHubActions;report-warnings=false"
shell: bash
env:
Test__Npgsql__DefaultConnection: Server=localhost;Username=npgsql_tests;Password=npgsql_tests
Test__Npgsql__DefaultConnection: Server=localhost;Username=npgsql_tests;Password=npgsql_tests;SSL Mode=Disable

- id: analyze_tag
name: Analyze tag
Expand Down
6 changes: 2 additions & 4 deletions test/EFCore.PG.FunctionalTests/TestUtilities/NpgsqlTestStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,7 @@ private static T ExecuteCommand<T>(
}
finally
{
if (connection.State == ConnectionState.Closed
&& connection.State != ConnectionState.Closed)
if (connection.State != ConnectionState.Closed)
{
connection.Close();
}
Expand Down Expand Up @@ -389,8 +388,7 @@ private static async Task<T> ExecuteCommandAsync<T>(
}
finally
{
if (connection.State == ConnectionState.Closed
&& connection.State != ConnectionState.Closed)
if (connection.State != ConnectionState.Closed)
{
await connection.CloseAsync();
}
Expand Down
Loading