Skip to content

fix(arborist): allow registry bundle inspection in dry runs - #9818

Open
yszgj-30 wants to merge 1 commit into
npm:latestfrom
yszgj-30:agent/fix-registry-tarball-dry-run
Open

fix(arborist): allow registry bundle inspection in dry runs#9818
yszgj-30 wants to merge 1 commit into
npm:latestfrom
yszgj-30:agent/fix-registry-tarball-dry-run

Conversation

@yszgj-30

Copy link
Copy Markdown

Summary

  • share the existing registry-resolved tarball validation between reification and ideal-tree building
  • apply the registry tarball exemption when a complete ideal tree inspects bundled dependencies
  • add a regression test for allowRemote=none

Root cause

Complete ideal-tree builds crack open tarballs for packages with bundled dependencies. That path passed the registry tarball URL directly to pacote.extract(), which classified it as a remote dependency and rejected it under the default allowRemote=none policy.

The fix only overrides that policy after the existing origin and registry-path checks confirm that the effective URL is registry-mediated.

Validation

  • reproduced npm install --dry-run npm@11.10.0 --allow-remote=none failing with EALLOWREMOTE before the fix
  • verified the same command exits 0 after the fix
  • passed the focused ideal-tree regression test
  • passed the existing 18-test registry URL and allowRemote reify group
  • passed node . run lint -w @npmcli/arborist

Fixes #9800

@yszgj-30
yszgj-30 marked this pull request as ready for review July 29, 2026 13:44
@yszgj-30
yszgj-30 requested review from a team as code owners July 29, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] --dry-run fails with EALLOWREMOTE on registry tarballs for packages that declare bundleDependencies

1 participant