fix(arborist): honor allowRemote exemption for registry bundle tarball - #9819
Draft
gopalsunkari860 wants to merge 1 commit into
Draft
fix(arborist): honor allowRemote exemption for registry bundle tarball#9819gopalsunkari860 wants to merge 1 commit into
gopalsunkari860 wants to merge 1 commit into
Conversation
…ls under --dry-run/--package-lock-only (npm#9800)
gopalsunkari860
marked this pull request as ready for review
July 29, 2026 15:19
gopalsunkari860
marked this pull request as draft
July 29, 2026 15:24
gopalsunkari860
marked this pull request as ready for review
July 29, 2026 15:39
gopalsunkari860
marked this pull request as draft
July 29, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes --dry-run/--package-lock-only throwing EALLOWREMOTE on registry packages that declare bundleDependencies.
The ideal-tree build "cracks open" the tarball to read bundled deps, but that pacote.extract call was missing the same
registry-tarball allowRemote exemption that reify()'s real extraction path already applies, so pacote's own
allow-remote gate mis-fired on ordinary registry tarballs. Extracted the exemption check into a shared helper used by
both paths, and added a regression test
Root cause: GitHub issue #9800 — npm install --dry-run (and --package-lock-only) crash with EALLOWREMOTE on any
registry package that declares bundleDependencies, even though a real install of the same package succeeds.