Restore an old link from policies using redirect #1587
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logos and usage policies page pretty much have contents from the [trademark page](https://web.archive.org/web/20220315191357/https://docs.npmjs.com/policies/trademark) that moved back in 2022/2023. As the previous link is still around, this redirect should function better than a 404.
leobalter
requested review from
Copilot and
a team
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR restores a redirect from the old policies/trademark URL to the current policies/logos-and-usage page to prevent 404s.
- Adds a new redirect entry in
cli/lib/redirects.jsfor the trademarks policy page.
Comments suppressed due to low confidence (2)
cli/lib/redirects.js:65
- Add a unit test to verify that the '/policies/trademark' path correctly redirects to '/policies/logos-and-usage'.
'policies/trademark': () => ['policies/logos-and-usage'],
cli/lib/redirects.js:64
- Align the indentation of the new comment and property with existing entries (use 4 spaces) to maintain consistent code style.
// policies
owlstronaut
approved these changes
May 20, 2025
leobalter
added a commit
that referenced
this pull request
May 20, 2025
Supersedes #1587 This redirect restores an old link from trademark policies to our logos and usages page. The logos and usage policies page pretty much have contents from the trademark page that moved back in 2022/2023. As the previous link is still around, this redirect should function better than a 404.
leobalter
added a commit
that referenced
this pull request
May 20, 2025
This redirect restores an old link from trademark policies to our logos and usages page. The logos and usage policies page pretty much have contents from the trademark page that moved back in 2022/2023. As the previous link is still around, this redirect should function better than a 404. ## References Supersedes #1587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logos and usage policies page pretty much have contents from the trademark page that moved back in 2022/2023.
As the previous link is still around, this redirect should function better than a 404.