Skip to content

Fix fluence rectangle transform #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

blakewalters
Copy link
Contributor

Fix input of transform applied to fluence scoring rectangle in the egs_fluence_scoring AO.

Previously, we looked for this input between the ":start/stop ausgab object:" delimiters instead of the ":start/stop planar scoring:" delimiters. As a result, it wasn't read in/applied.

@blakewalters blakewalters self-assigned this Feb 21, 2025
@blakewalters blakewalters requested a review from a team as a code owner February 21, 2025 22:46
@blakewalters blakewalters force-pushed the fix-fluence_rectangle_transform branch from 391d9f4 to 3bc1b64 Compare February 21, 2025 22:57
@ftessier ftessier force-pushed the fix-fluence_rectangle_transform branch from b423a62 to 8cce5f6 Compare March 14, 2025 20:42
Copy link
Contributor

@mainegra mainegra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the three commits, only the one related to the tranformation input is relevant. The other two seem more like debugging tests?

@ftessier
Copy link
Member

Yes, these commits will be squashed before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants