Fix BEAMnrc synchdmlc component module bugs #878
Conversation
|
@blakewalters this series of commits also include the radiative splitting ausgab object. Let me know if this is intentional, and I will split the pull request between synchdmlc and the ausgab object. |
|
@blakewalters Oh I see, you already removed the changes related to radiative splitting in later commits... |
ftessier
force-pushed
the
fix_synchdmlc_bugs
branch
from
941c867 to
a84ffee
Compare
|
Extracted the ausgab object radiative splitting commits from this pull request branch, and put them on a new branch |
ftessier
force-pushed
the
fix_synchdmlc_bugs
branch
from
a84ffee to
c825389
Compare
|
Rebased on develop without conflict. |
ftessier
force-pushed
the
fix_synchdmlc_bugs
branch
from
c825389 to
ef77128
Compare
|
Adjusted commit messages, squashed some commits together. Verified that there is no diff with the original pull request head. |
ftessier
force-pushed
the
fix_synchdmlc_bugs
branch
from
ef77128 to
db8b51b
Compare
|
Squashed a couple more commits, tweaked messages. Verified that there is no diff with the original pull request head. |
ftessier
changed the title
|
Removed EOL whitespace in files modified by the pull request. No diff apart from whitespace, as confirmed with |
|
@blakewalters please confirm that you are ok with the cleaned up branch. @rtownson amd @mainegra please review when you get a change. |
|
Looks good, @ftessier! Thanks for cleaning it up. |
Restore some code from DYNVMLC that seemed necessary to avoid changing regions when the particle had not actually traveled as far as the region boundary.
Note that commented out debug write statements are still present in the source code.
Note that commented out debug write statements are still present in the source code.
Also comment out debug write statements.
Add $SYNCHDMLC_ORIENT options to flip leaf numbering and cross-sections with respect to the axis perpendicular to the opening axis, so that the MLC coordinate system matches that in the manufacturer (Varian) specs for 120MLC and HD120. This reflection reverses the order of leaf numbering, hence leaf opening sequences are automatically "flipped" so that the opening coordinate applied to leaf i is instead applied to leaf N-i+1, where N is the total number of leaves. See the updated BEAMnrc manual for more details. Also, add new ORIENT=2,3 options to SYNCHDMLC gui
Reverse leaf opening sequence definition for option ORIENT_$SYNCHDMLC=2,3
Reorder cross section y boundaries when input restrictions are relaxed.
ftessier
force-pushed
the
fix_synchdmlc_bugs
branch
from
7d7f59e to
5e0b122
Compare
|
Updated a couple commit messages and squashed one. No code change. |
Fixed many small bugs in transport through leaf cross-sections. Some of these were introduced with the override of some cross-section dimensions necessary to accurately model the 120MLC and HD120 collimators back in 2018. However, some of these bugs predate that change.
This PR also includes new leaf orientation options for SYNCHDMLC, ORIENT=2,3, which automatically reflect leaves about the axis perpendicular to the leaf opening direction so that the MLC coordinate system matches that in the manufacturer (Varian) specs for 120MLC and HD120. This reflection reverses the order of leaf numbering, and so leaf opening sequences are automatically "flipped" so that the opening coordinate applied to leaf i is instead applied to leaf N-i+1, where N is the total no. of leaves. See the updated BEAMnrc manual for more details.
Many thanks to Dr. Jarkko Ojala without whose collaboration these fixes and enhancements would not have been possible.