-
Notifications
You must be signed in to change notification settings - Fork 18
Bump dependencies and svd files. #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a4786bb to
a60f6cb
Compare
|
I think I fixed the Also, I understand this PR is just ludicrously huge, so much that any review becomes meaningless, but I'm willing to discuss splitting this up or help in any way the review process, also synchronously if necessary. |
8bd5119 to
ccba521
Compare
@blkt Cargo's semver is not precisely like the official semver. Bumping the leftmost non-zero is a major change, which is appropriate for something like this.
You're not wrong. This PR is not possible to review as-is. |
|
Hey @9names sure, I'll do that, just keep in mind that I work on this in my free time, so it's gonna be during the (late) evening. |
|
Cool. I help maintain this project in my free time and I'm statistically unlikely to live in the same timezone as you, feel free to do the work whenever you would like. |
This change bumps `cortex-m`, `critical-section`, and build dependencies `form` and `svd2rust`.
This change bumps `xshell` dependency. It's a minor version update and some signatures had to change to address the fact that now `Shell` is not implicitly available to all routines.
This is the result of running `cargo xtask generate`.
ccba521 to
74cf24c
Compare
|
Hi @9names I split the code into a few commits, it should make it easier to understand the nature of changes. The resulting code for PACs is slightly different from the last iteration for some reason, you can see the old version here. For future reference, I downloaded SVD files form Nordic Semi website and fixed some minor issue with casing around |
This change updates
cortex-mdependency as well assvd2rust, which required updating xtask source code too. Effectively,svd2rustwas the biggest update in terms of dependencies.This also updates SVD files for all nRF chips to the latest version.
I presume this is going to introduce breaking changes all over the place, so I also bumped the minor version (which is not exactly semver, but it felt arrogant to bump the major).