Add enable/disable interrupt helper functions#8
Open
jamesmunns wants to merge 2 commits intonrf-rs:mainfrom
Open
Add enable/disable interrupt helper functions#8jamesmunns wants to merge 2 commits intonrf-rs:mainfrom
jamesmunns wants to merge 2 commits intonrf-rs:mainfrom
Conversation
Contributor
|
Sorry, only saw this today since I wasn't watching the repo. Not sure if you still need this, but some thoughts: It looks like our |
bors bot
added a commit
that referenced
this pull request
Sep 27, 2022
12: Return `Self` from `Usbd::new` r=jonas-schievink a=jonas-schievink This makes the `device_address` method usable, and allows adding more methods in the future (although they'll only work before the bus is initialized). Also build/check the example by default. cc #8 Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned on matrix, I wanted to switch from regular polling to interrupt driving of the USB handler.
This interface is awkward, because
Usbdreturns aBusAllocator, which really gives no way (I can see?) to take access to the relevant USBD peripheral.Additionally, we probably should only enable endpoint interrupts (
endepin*andendepout*) that we are actually using (so enable them on allocation), but I would hope they wouldn't fire if the endpoint isn't being used?Feel free to reject this if it's too "funky", but I ended up writing these for my own project, and they seem to work well.