Skip to content

tests: cloud: Use strnlen() for ssafety #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtguggedal merged 1 commit into from
Mar 19, 2025
Merged

tests: cloud: Use strnlen() for ssafety #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/module/cloud/src/cloud_module_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,18 @@
*
* SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
*/

/* Ensure 'strnlen' is available even with -std=c99. */
#if !defined(_POSIX_C_SOURCE)
#define _POSIX_C_SOURCE 200809L
#endif

#include <unity.h>
#include <zephyr/fff.h>
#include <zephyr/task_wdt/task_wdt.h>
#include <zephyr/net/coap.h>
#include <zephyr/net/coap_client.h>
#include <zephyr/zbus/zbus.h>

#include "environmental.h"
#include "cloud_module.h"
Expand Down Expand Up @@ -185,7 +192,7 @@ void test_sending_payload(void)
struct cloud_msg msg = {
.type = CLOUD_PAYLOAD_JSON,
.payload.buffer = "{\"test\": 1}",
.payload.buffer_data_len = strlen(msg.payload.buffer),
.payload.buffer_data_len = strnlen(msg.payload.buffer, sizeof(msg.payload.buffer)),
};

err = zbus_chan_pub(&CLOUD_CHAN, &msg, K_SECONDS(1));
Expand Down Expand Up @@ -222,7 +229,7 @@ void test_connected_paused_to_ready_send_payload(void)
struct cloud_msg msg = {
.type = CLOUD_PAYLOAD_JSON,
.payload.buffer = "{\"Another\": \"test\"}",
.payload.buffer_data_len = strlen(msg.payload.buffer),
.payload.buffer_data_len = strnlen(msg.payload.buffer, sizeof(msg.payload.buffer)),
};

/* Reset call count */
Expand Down
Loading