Merged
Conversation
Check the expected events instead of purging channels. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Main was listed twice, remove the second entry. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Shadow polling should only happen when location polling is completed. This is done for two reasons: - To not interrupt location search with network traffic - Reduce number of RRC connections. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🎯 Core Changes
- The main purpose of this PR is to streamline cloud message handling in the
main.cfile by consolidating cloud message publications into thesensor_and_poll_triggers_sendfunction and removing redundant publications from thesample_data_entryfunction. - Test cases in
tests/module/main/src/main.chave been updated to include additional checks for network quality and power battery percentage sample requests, ensuring comprehensive test coverage.
- No major concerns identified. The changes seem to enhance code efficiency and test coverage without introducing new risks.
Verdict:
- Approve: The changes improve the codebase by reducing redundancy and enhancing test coverage. They are safe to merge.
Code review performed by OPENAI - gpt-4o.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
README.mdfile and themain.cfiles in both the application and test modules. The most important changes include removing a module reference from theREADME.md, adding a new cloud message publication in thesensor_and_poll_triggers_sendfunction, and modifying thesample_data_entryfunction to remove redundant cloud message publications.Documentation updates:
README.md: Removed the reference to theMainmodule from the documentation list.Code updates in
app/src/main.c:sensor_and_poll_triggers_send: Added a new cloud message publication to send a shadow trigger.sample_data_entry: Removed redundant cloud message publication to simplify the function.Test updates in
tests/module/main/src/main.c:test_trigger_interval_change_in_connected: Added checks for network quality and power battery percentage sample requests.test_trigger_disconnect_and_connect_when_triggering: Removed redundant event purging to streamline the cleanup process.