modules: cloud: Rename from cloud_module to cloud#222
Merged
jtguggedal merged 1 commit intomainfrom Apr 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the cloud module to align with other modules. Major updates include:
- Renaming header files and include guards from cloud_module to cloud.
- Updating documentation and test references to reflect the new naming.
- Changing thread identifiers in the cloud module implementation.
Reviewed Changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/module/main/src/main.c | Updated cloud header include from cloud_module to cloud. |
| tests/module/cloud/src/cloud_module_test.c | Updated cloud header include from cloud_module to cloud. |
| docs/modules/cloud.md | Updated documentation references from cloud_module to cloud. |
| docs/common/tooling_troubleshooting.md | Renamed thread identifier reference. |
| app/src/modules/cloud/cloud_shell.c | Updated cloud header include from cloud_module to cloud. |
| app/src/modules/cloud/cloud.h | Updated include guards from CLOUD_MODULE_H to CLOUD_H. |
| app/src/modules/cloud/cloud.c | Updated cloud header include and thread identifier, but a naming mismatch exists. |
| app/src/main.c | Updated cloud header include from cloud_module to cloud. |
Files not reviewed (3)
- app/src/modules/cloud/CMakeLists.txt: Language not supported
- docs/patches/magnetometer.patch: Language not supported
- tests/module/cloud/CMakeLists.txt: Language not supported
To align with other modules, rename to cloud. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
jtguggedal
force-pushed
the
cloud-rename
branch
from
5250a23 to
07a7d19
Compare
|
There was a problem hiding this comment.
Pull Request Overview
This PR renames the cloud module to simply "cloud" to align with naming conventions used in other modules.
- Renames include directives and file references from cloud_module to cloud
- Updates function and thread names accordingly in the source and test files
Reviewed Changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/module/main/src/main.c | Updated include directive from cloud_module.h to cloud.h. |
| tests/module/cloud/src/cloud_module_test.c | Updated include directive from cloud_module.h to cloud.h in tests. |
| docs/modules/cloud.md | Updated file references and documentation text. |
| docs/common/tooling_troubleshooting.md | Updated thread name references in log output. |
| app/src/modules/cloud/cloud_shell.c | Updated include directive from cloud_module.h to cloud.h. |
| app/src/modules/cloud/cloud.h | Renamed include guards and comments to use cloud instead of cloud_module. |
| app/src/modules/cloud/cloud.c | Renamed function and thread definitions from cloud_module to cloud. |
| app/src/main.c | Updated include directive from cloud_module.h to cloud.h. |
Files not reviewed (3)
- app/src/modules/cloud/CMakeLists.txt: Language not supported
- docs/patches/magnetometer.patch: Language not supported
- tests/module/cloud/CMakeLists.txt: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with other modules, rename to cloud.