app: refactor and align code

[DematteisGiacomo]

Refactor and align code across modules.

[Copilot]

Pull Request Overview

This PR refactors and aligns code across modules by standardizing naming conventions, function parameter names, and thread/callback identifiers. Key updates include renaming state objects and callback functions for clarity, updating comments, and improving consistency in module threading and watchdog handling.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
app/src/modules/power/power.c	Updated state struct naming and renamed function parameters and callbacks.
app/src/modules/network/network.c	Reformatted module state enum and updated inline comments.
app/src/modules/location/location.c	Renamed state object and function parameters to improve consistency.
app/src/modules/fota/fota.c	Standardized state handler declarations and thread/callback naming.
app/src/modules/environmental/environmental.c	Applied naming consistency and updated log module registration.
app/src/modules/cloud/cloud.c	Refactored state object and state handler names; improved logging.

Comments suppressed due to low confidence (1)

app/src/modules/network/network.c:62

• Typo in comment: 'disconencted' should be corrected to 'disconnected'.

/* The device is disconencted from network and is not searching */

[sonarqubecloud]

Quality Gate passed

Issues
26 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jorgenmk]

Indentation as intended here?

[DematteisGiacomo]

yes, to highlight the hierarchies in the state machine. Other modules (cloud and fota) have the same