cloud: fix fallback provisioning network state handling#394
Merged
simensrostad merged 1 commit intomainfrom Sep 26, 2025
Merged
cloud: fix fallback provisioning network state handling#394simensrostad merged 1 commit intomainfrom
simensrostad merged 1 commit intomainfrom
Conversation
simensrostad
force-pushed
the
fix-fallback-provisioning
branch
2 times, most recently
from
9991e28 to
a92e6f0
Compare
The fallback provisioning logic incorrectly determined the next state when provisioning failed. The network_connected variable was not being updated properly, causing incorrect state transitions. This fix ensures the network connection status is checked accurately before determining whether to retry provisioning or transition to an offline state. Added corresponding unit tests to verify the correct behavior of the fallback provisioning logic under different network conditions. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
simensrostad
force-pushed
the
fix-fallback-provisioning
branch
from
a92e6f0 to
cc285d6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback provisioning logic incorrectly determined the next state when provisioning failed. The network_connected variable was not being updated properly, causing incorrect state transitions.
This fix ensures the network connection status is checked accurately before determining whether to retry provisioning or transition to an offline state.
Added corresponding unit tests to verify the correct behavior of the fallback provisioning logic under different network conditions.