Skip to content

memfault: Pull in latest Memfault fixes in sdk-nrf #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simensrostad merged 1 commit into from
Dec 18, 2025
Merged

memfault: Pull in latest Memfault fixes in sdk-nrf #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/overlay-memfault.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ CONFIG_MEMFAULT_COREDUMP_FULL_THREAD_STACKS=y
## Disable location metrics due to not being properly implemented for external handling of location
## requests when using the location library.
CONFIG_MEMFAULT_NCS_LOCATION_METRICS=n
CONFIG_MEMFAULT_NRF_PLATFORM_BATTERY_NPM13XX=y

# Certificate management
CONFIG_MEMFAULT_ROOT_CERT_STORAGE_NRF9160_MODEM=y
Expand Down
13 changes: 0 additions & 13 deletions app/src/modules/cloud/cloud.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,19 +949,6 @@ static void state_connected_entry(void *obj)

LOG_DBG("%s", __func__);
LOG_INF("Connected to Cloud");

#if defined(CONFIG_MEMFAULT)
if (memfault_coredump_has_valid_coredump(NULL)) {
/* Initial update to Memfault is handled internally in the
* Memfault LTE coredump layer.
*/
return;
}

/* No coredump available, trigger an initial update to Memfault. */
(void)memfault_metrics_heartbeat_debug_trigger();
(void)memfault_zephyr_port_post_data();
#endif /* CONFIG_MEMFAULT */
}

static void state_connected_exit(void *obj)
Expand Down
2 changes: 1 addition & 1 deletion west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ manifest:
- name: nrf
remote: ncs
repo-path: sdk-nrf
revision: a4367fdc0db21331df42b79fd16d5797b559f732
revision: 0d2caeecd6a850649d992885cd8e7994da91933c
import: true