Storage flash backend #501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trond-F-Christiansen
force-pushed
the
storage-flash-backend
branch
5 times, most recently
from
02da245 to
930471b
Compare
app/src/modules/cloud/cloud.h
Outdated
| * -EALREADY if the provided time was already in unix time (>= 2026-01-01), | ||
| * -ENODATA if date time is not valid, | ||
| */ | ||
| static inline int64_t attempt_timestamp_to_unix_ms(int64_t *uptime_ms) |
Contributor
There was a problem hiding this comment.
Should the ifs be spaced?
| target_sources_ifdef(CONFIG_APP_STORAGE_BACKEND_LITTLEFS app PRIVATE | ||
| backends/littlefs_backend.c | ||
| ) | ||
|
|
| /* Drop oldest when full to overwrite */ | ||
| header.read_offset++; | ||
| LOG_WRN("Storage file %s full, overwriting oldest data", file_path); | ||
| } |
jtguggedal
reviewed
Jan 15, 2026
Comment on lines
+360
to
+406
| LOG_WRN("Setting timestamp to current time"); | ||
| return 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| LOG_WRN("Setting timestamp to current time"); | |
| return 0; | |
| LOG_WRN("Setting timestamp to current time"); | |
| return 0; |
Comment on lines
+363
to
+409
| *timestamp_ms = NRF_CLOUD_NO_TIMESTAMP; | ||
| return 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| *timestamp_ms = NRF_CLOUD_NO_TIMESTAMP; | |
| return 0; | |
| *timestamp_ms = NRF_CLOUD_NO_TIMESTAMP; | |
| return 0; |
Comment on lines
381
to
432
| timestamp_ms = msg->timestamp; | ||
| err = handle_data_timestamp(×tamp_ms); | ||
| if (err) { |
Contributor
There was a problem hiding this comment.
Suggested change
| timestamp_ms = msg->timestamp; | |
| err = handle_data_timestamp(×tamp_ms); | |
| if (err) { | |
| timestamp_ms = msg->timestamp; | |
| err = handle_data_timestamp(×tamp_ms); | |
| if (err) { |
Comment on lines
+351
to
+395
| LOG_WRN("Keeping original timestamp value"); | ||
| return 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| LOG_WRN("Keeping original timestamp value"); | |
| return 0; | |
| LOG_WRN("Keeping original timestamp value"); | |
| return 0; |
Contributor
There was a problem hiding this comment.
Nitpicks incoming, will not comment on them all
Comment on lines
354
to
400
| *timestamp_ms = k_uptime_get(); | ||
| err = attempt_timestamp_to_unix_ms(timestamp_ms); | ||
| if (err) { |
Contributor
There was a problem hiding this comment.
Suggested change
| *timestamp_ms = k_uptime_get(); | |
| err = attempt_timestamp_to_unix_ms(timestamp_ms); | |
| if (err) { | |
| *timestamp_ms = k_uptime_get(); | |
| err = attempt_timestamp_to_unix_ms(timestamp_ms); | |
| if (err) { |
| static void create_storage_file_path(const struct storage_data *type, char *out_path, | ||
| size_t max_len) | ||
| { | ||
| snprintf(out_path, max_len, "%s/%s.bin", mountpoint.mnt_point, type->name); |
Contributor
There was a problem hiding this comment.
Suggested change
| snprintf(out_path, max_len, "%s/%s.bin", mountpoint.mnt_point, type->name); | |
| err = snprintk(out_path, max_len, "%s/%s.bin", mountpoint.mnt_point, type->name); |
Return value should be checked, so this function should probably return an int
| max_records_per_type = total_storage_size / total_data_size; | ||
|
|
||
| if (max_records_per_type < RECORDS_PER_TYPE) { | ||
| LOG_WRN("Configured max records per type (%d) exceeds calculated capacity (%d). " |
Contributor
There was a problem hiding this comment.
This log message takes up a decent amount of flash, could it be compressed?
| ssize_t rc; | ||
|
|
||
| /* If data is NULL, use temporary buffer to verify data exists */ | ||
| uint8_t temp_buffer[type->data_size]; |
Contributor
There was a problem hiding this comment.
We might want to make this static to avoid blowing up the stack
| return -EINVAL; | ||
| } | ||
|
|
||
| /* Open storage file */ |
Contributor
There was a problem hiding this comment.
This function needs some air in form of blank lines
| ssize_t rc; | ||
|
|
||
| if (!type) { | ||
| return -EINVAL; |
Contributor
There was a problem hiding this comment.
You could even assert here, it's a programming error that should not happen when a static function is called with invalid arguments
SyverHaraldsen
approved these changes
Jan 15, 2026
Contributor
SyverHaraldsen
left a comment
SyverHaraldsen
left a comment
There was a problem hiding this comment.
This is really good, and super cool.
Just nit-pick; there are a few places with inconsistent spacing. Pointed out just a couple.
Trond-F-Christiansen
force-pushed
the
storage-flash-backend
branch
2 times, most recently
from
c6ab86c to
cee43d6
Compare
Changes module msg timestamps to unix time at sample creation if possible. If conversion fails, original uptime value is kept. Reattempts conversion if needed before sending to cloud, if still not possible handle error based on Kconfig setting. Signed-off-by: Trond F. Christiansen <[email protected]>
Remove the unused memory slabs from the storage_data struct, and its alocation. Signed-off-by: Trond F. Christiansen <[email protected]>
Add littleFS based flash storage backend for the storage module. Uses a file per storage data type to store a circular buffer of records. Signed-off-by: Trond F. Christiansen <[email protected]>
Trond-F-Christiansen
force-pushed
the
storage-flash-backend
branch
from
cee43d6 to
bfce8fb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds littlefs based flash backend for the storage module