modules: main: Use fallback state when sampling happens too soon #503
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following scenario, the state machine may be stuck in sampling state without ever actually sampling: - Sampling in connected state - Losing connection - Entering disconnected state immediately attempting to sample - Failing check to sample because it is too soon after previous sample - Stuck in sampling state, but not sampling. No location event is received, so state machine is stuck here. Introducing a fallback state argument to the function doing the check addresses this. Signed-off-by: Jan Tore Guggedal <[email protected]>
SyverHaraldsen
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following scenario, the state machine may be stuck in sampling state without ever actually sampling:
Introducing a fallback state argument to the function doing the check addresses this.