modules: network: Fix network disconnect when searching #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where network search was not stopped when NETWORK_DISCONNECT or NETWORK_STOP_SEARCH was received in STATE_DISCONNECTED_SEARCHING. Instead, there was just a transition to STATE_DISCONNECTED_IDLE while the search kept going in the background. This patch adds an explicit disconnection call before transitioning state. Signed-off-by: Jan Tore Guggedal <[email protected]>
Update the storage module plant UML to be in line with the current state machine design. Signed-off-by: Jan Tore Guggedal <[email protected]>
jtguggedal
force-pushed
the
network-stop-search
branch
from
ddf18b7 to
f0e7123
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where network search was not stopped when NETWORK_DISCONNECT or NETWORK_STOP_SEARCH was received in STATE_DISCONNECTED_SEARCHING. Instead, there was just a transition to STATE_DISCONNECTED_IDLE while the search kept going in the background.
This patch adds an explicit disconnection call before transitioning state.