app: remove inspect shell#687
Merged
Merged
Conversation
Remove the `app_inspect` module and all related `APP_INSPECT_MODULE_REGISTER_STATE` registrations from all modules (main, cloud, environmental, fota, location, network, storage). Also removes the `src/inspect` directory with its Kconfig, CMake, linker script, and source files. This is done to reduce the code size of the application. To inspect the state of the application, use the state inspection script instead, which can be found under `scripts/inspect_state.py`. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
Contributor
|
App size changed. See CI run text data bss dec hex flash% ram%
--- baseline
+++ pr
@@ -2 +2 @@
- 398752 158497 190466 747715 b68c3 70.86% 83.95%
+ 398740 158497 190466 747703 b68b7 70.86% 83.95% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
app_inspectmodule and all relatedAPP_INSPECT_MODULE_REGISTER_STATEregistrations from all modules (main, cloud, environmental, fota, location, network, storage). Also removes thesrc/inspectdirectory with its Kconfig, CMake, linker script, and source files.This is done to reduce the code size of the application. To inspect the state of the application, use the state inspection script instead, which can be found under
scripts/inspect_state.py.