lib: sgp4: move SGP4 from app module to shared library#688
Merged
Conversation
Contributor
|
App size did not change. See CI run |
Move the SGP4 implementation from `app/src/modules/sgp4` to a new `lib/sgp4` library so it can be used as a proper Zephyr library, decoupled from the app module system. The new library splits `SGP4_PASS_PREDICT` into a separate Kconfig option. Tests are updated to use the new library path and enable `CONFIG_SGP4_PASS_PREDICT` via `prj.conf` instead of directly including source files. Also removes the `at_monitor` dependency from `sgp4_pass_predict.c`. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
simensrostad
force-pushed
the
att/remove/shell-cmd
branch
from
3ba2722 to
84d8689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the SGP4 implementation from
app/src/modules/sgp4to a newlib/sgp4library so it can be used as a proper Zephyr library, decoupled from the app module system.The new library splits
SGP4_PASS_PREDICTinto a separate Kconfig option. Tests are updated to use the new library path and enableCONFIG_SGP4_PASS_PREDICTviaprj.confinstead of directly including source files.Also removes the
at_monitordependency fromsgp4_pass_predict.c.