lib: sgp4: move tests from module to lib, expose public API#690
Merged
Conversation
simensrostad
force-pushed
the
att/fix/sgp4/tests
branch
from
41002b0 to
f971ad2
Compare
Contributor
|
App size did not change. See CI run |
simensrostad
force-pushed
the
att/fix/sgp4/tests
branch
from
6004fb6 to
d2630d7
Compare
Move NTN tests from `tests/module/` to `tests/lib/` and update testcase identifiers from `fw` to `lib` prefix. Move `sat_data_sib32` struct to the header and expose `parse_sibconfig32_at` and `jd_from_unix_time_ms` as public functions with proper documentation. Use `ASSET_TRACKER_TEMPLATE_DIR` variable in CMake files instead of relative paths. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
simensrostad
force-pushed
the
att/fix/sgp4/tests
branch
from
d2630d7 to
01f37dc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move NTN tests from
tests/module/totests/lib/and update testcase identifiers fromfwtolibprefix.Move
sat_data_sib32struct to the header and exposeparse_sibconfig32_atandjd_from_unix_time_msas public functions with proper documentation.Use
ASSET_TRACKER_TEMPLATE_DIRvariable in CMake files instead of relative paths.