Merged
Conversation
simensrostad
force-pushed
the
updatefotaapp
branch
from
571fc42 to
c7b7f4e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🎯 Core Changes:
- Enhanced FOTA (Firmware Over The Air) state machine with additional states to handle different update scenarios
- Renamed and clarified FOTA message types for better readability
- Added new state transitions for network disconnection and image application
None - Changes improve state handling without introducing risks
Verdict: Approve - Changes improve FOTA process clarity and robustness
Code review performed by ANTHROPIC - claude-3-5-sonnet-20241022.
Include more states in app.c to differ between different FOTA scenarios. Change events according to offline state diagrams. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
simensrostad
force-pushed
the
updatefotaapp
branch
from
c7b7f4e to
00b34f9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include more states in app.c to differ between different FOTA scenarios.