Merged
Conversation
DematteisGiacomo
force-pushed
the
add_main_function
branch
from
60ddf7b to
6f1ca8a
Compare
Add a main thread with zbus subscriber instead of callback. Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
DematteisGiacomo
force-pushed
the
add_main_function
branch
from
6f1ca8a to
0a5c542
Compare
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🎯 Core Changes
- Introduced a main function with a zbus subscriber, replacing the previous callback mechanism.
- Added configurations for watchdog and message processing timeouts in
Kconfig.main. - Modified the
main.cfile to use a state machine approach for handling different states of the application. - Updated the test setup to accommodate the new main function structure.
- None identified.
Verdict:
- Approve: The changes are well-structured and improve the modularity and maintainability of the application by using a state machine and zbus subscriber approach.
Code review performed by OPENAI - gpt-4o.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a main thread with zbus subscriber instead of callback.