matter: Implement NFC commissioning manger - #22
Conversation
f2ef017 to
07973ae
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
NordicBuilder
added
manifest
manifest-matter
DNM
|
You can find the documentation preview for this PR here. |
dafb199 to
6836fb0
Compare
6836fb0 to
6befce4
Compare
6befce4 to
1a6b39c
Compare
| Advanced configuration options | ||
| ============================== | ||
|
|
||
| .. include:: /includes/configuration/advanced/intro.txt |
There was a problem hiding this comment.
Minor, but shouldn't we have some more sections that are present in other samples, like dfu, factory data etc? Or we may not add it at all to be consistent.
There was a problem hiding this comment.
Maybe, but it is out of socope of this PR.
There was a problem hiding this comment.
We can create a follow-up task for that
There was a problem hiding this comment.
Task description is going to have more lines than expected change, but ok
| ====================== | ||
|
|
||
| You can configure the Matter protocol to use NFC tag for commissioning, instead of the default QR code. | ||
| You can configure the Matter protocol to use an NFC tag for commissioning, instead of relying only on a printed QR code or Bluetooth LE. |
There was a problem hiding this comment.
This sentence mixes a bit two different things. How about splitting it into separate bullet points, like:
You can configure the Matter protocol to use an NFC tag for different purposes:
- Device onboarding, instead of relying on QR code
- Full device commissioning instead of using Bluetooth LE
| CONFIG_MATTER_TEST_SHELL=y | ||
|
|
||
| # Disable NFC onboarding | ||
| CONFIG_CHIP_NFC_ONBOARDING_PAYLOAD=n |
There was a problem hiding this comment.
AS discussed f2f, let's leave it as is.
| @@ -0,0 +1,49 @@ | |||
| NFC-based commissioning | |||
There was a problem hiding this comment.
We need to mention somewhere that from the practical use case perspective there are tags that support unpowered mode and powered only mode. And make sure it's clear we support only powered mode, otherwise customer may expect it is going to work unpowered, because this is main marketing use case for this feature.
1a6b39c to
cd67b71
Compare
|
@kkasperczyk-no @peknis I've added changes requested by Kamil. Could you please take a look? |
85c640e to
e17b2eb
Compare
Updated sdk-connectedhomeip to fetch nRFConnect commissioning manager implementation. Adjusted Matter Init and Event Handler to work with NFC commissioning. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
e17b2eb to
b253258
Compare
4 participants
Updated sdk-connectedhomeip to fetch nRFConnect commissioning manager implementation.
Adjusted Matter Init and Event Handler to work with NFC commissioning.