Fix datamodel configuration in samples - #35
Merged
ArekBalysNordic merged 7 commits intoAug 21, 2026
Merged
Conversation
NordicBuilder
added
manifest
manifest-matter
DNM
ArekBalysNordic
changed the title
ArekBalysNordic
force-pushed
the
fix_datamodel_post_1_6
branch
from
August 17, 2026 08:49
d91da5b to
93d2198
Compare
ArekBalysNordic
changed the title
ArekBalysNordic
force-pushed
the
fix_datamodel_post_1_6
branch
2 times, most recently
from
August 17, 2026 10:33
ab6a826 to
b982303
Compare
|
You can find the documentation preview for this PR here. Preview links for modified Matter add-on documents: |
ArekBalysNordic
force-pushed
the
fix_datamodel_post_1_6
branch
3 times, most recently
from
August 17, 2026 12:13
f53b3dc to
c4c1099
Compare
ArekBalysNordic
removed
DNM
| clusterStorage.Create(kThreadNetworkDiagnosticsEndpointId, clusterType, sDirectProvider); | ||
| ReturnErrorOnFailure(registry.Register(clusterStorage.Registration())); | ||
|
|
||
| IsClusterReplaced() = true; |
Collaborator
There was a problem hiding this comment.
That looks really weird. Maybe we should name this method in a different way.
Collaborator
Author
There was a problem hiding this comment.
But... This function replaces the original one :) Will think about something different
peknis
requested changes
Aug 19, 2026
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
NordicBuilder
added
manifest
manifest-matter
DNM
ArekBalysNordic
force-pushed
the
fix_datamodel_post_1_6
branch
from
August 19, 2026 08:52
20ec7e0 to
7fe6382
Compare
peknis
approved these changes
Aug 19, 2026
ArekBalysNordic
force-pushed
the
fix_datamodel_post_1_6
branch
2 times, most recently
from
August 19, 2026 14:08
974e4ba to
9e8ce0a
Compare
In the matter Upstream, zap generation does not generates the callback-stub and PluginApplicationCallbacks anymore, but they are still needed for static zap approach. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
Some attributes are optional and should not be enabled by default. Currently, the Matter stack implementation does not allow to disable them, but we can inherit the Cluster server, and provide required changes. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
emperature cluster revision 4 -> 6 level control cluster revision: 6 -> 7 pressure cluster cluster revision: 3 → 5 reality humidity cluster revision: 3-> 5 Device types cluster revision updates: window covering device type 3 → 6 temperature sensor device type 2 → 3 pressure sensor device type 2 → 3 relative humidity device type 2 → 3 thermostat device type 4 → 6 Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
ArekBalysNordic
force-pushed
the
fix_datamodel_post_1_6
branch
from
August 19, 2026 14:11
9e8ce0a to
30d603c
Compare
kkasperczyk-no
approved these changes
Aug 21, 2026
Updated Matter SDK revision to fetch new data model for TemperatureMeasurements and HumidityMeasurements. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
If PI (Pairing Instruction) is present then PH (Pairing Hint) must have at least one of bits [4, 8, 9, 10, 11, 12, 15, 16, 17, 18, 19, 20, 21, 22] present. The issue was that CHIP_DEVICE_CONFIG_PAIRING_SECONDARY_HINT was not set for the certification firmware alongside to CHIP_DEVICE_CONFIG_PAIRING_SECONDARY_INSTRUCTION. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
There was a missing Kconfig for manufacturing date. To pass the test we cannot use the default value. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
We should use |release| instead of raw numbers on the top of the version table. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
ArekBalysNordic
force-pushed
the
fix_datamodel_post_1_6
branch
from
August 21, 2026 11:31
e9f44b2 to
0e62395
Compare
ArekBalysNordic
added
the
ci-disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature map was set wrongly in Cluster server. We must overwrite it in the application.