Next fixes for Matter 1.6 - #46
Merged
ArekBalysNordic merged 4 commits intoAug 25, 2026
Merged
Conversation
ArekBalysNordic
requested review from
a team,
b-gent and
peknis
as code owners
August 24, 2026 15:04
peknis
approved these changes
Aug 25, 2026
| DECLARE_DYNAMIC_ATTRIBUTE_LIST_END(); | ||
|
|
||
| /* Codedriven delegate for the Identify cluster */ | ||
| class IdentifyBridgedDeviceDelegateImpl : public chip::app::Clusters::IdentifyDelegate { |
Collaborator
There was a problem hiding this comment.
Do we need to inform about it in some migration guide?
Collaborator
Author
There was a problem hiding this comment.
Added to a release note entry
ArekBalysNordic
force-pushed
the
matter_1_6_fixes_follow_up
branch
from
August 25, 2026 09:15
a15d431 to
2f4fe35
Compare
|
You can find the documentation preview for this PR here. Preview links for modified Matter add-on documents: |
peknis
requested changes
Aug 25, 2026
kkasperczyk-no
approved these changes
Aug 25, 2026
The identify cluster has been fixed in the Matter upstream repo, so now we can use it in a simpler way and also it fixes the new issue when identify works alongside group communication. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
Those two attributes of Thread Network Diagnostic Cluster are not compliant with the Matter 1.6 certification, so we should disable them for all samples. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
Let's assign ncs-matter-doc instead of specific people. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
Some tests were not included in the integration scope within sample.yaml files. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
ArekBalysNordic
force-pushed
the
matter_1_6_fixes_follow_up
branch
from
August 25, 2026 10:02
2f4fe35 to
062b3ef
Compare
peknis
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The identify cluster has been fixed in the Matter upstream repo, so now we can use it in a simpler way and also it fixes the new issue when identify works alongside group communication.
Those two attributes of Thread Network Diagnostic Cluster are not compliant with the Matter 1.6 certification, so we should disable them for all samples.