app: Add automatic data reception for sockets#102
Merged
Conversation
MarkusLassila
force-pushed
the
add-socket-immediate
branch
3 times, most recently
from
f4cea89 to
c03e01b
Compare
MarkusLassila
requested review from
SeppoTakalo,
Copilot,
juhaylinen and
trantanen
There was a problem hiding this comment.
Pull request overview
This pull request adds automatic receive functionality for socket data through a new AT command #XSOCKETMODE. The feature enables sockets to automatically receive and report incoming data as URC notifications, eliminating the need for manual receive commands.
Key Changes
- Introduces
#XSOCKETMODEAT command to configure automatic data reception for sockets in both AT-command mode and data mode - Refactors socket mode enumerations to unify send and receive mode handling
- Enhances poll event management to track and process delayed events across mode transitions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| doc/app/SOCKET_AT_commands.rst | Adds documentation for the new #XSOCKETMODE command with examples and response format references |
| app/src/sm_uart_handler.c | Updates URC sending logic to use in_at_mode() check instead of negated in_datamode() |
| app/src/sm_cmux.c | Updates URC sending logic to use in_at_mode() check instead of negated in_datamode() |
| app/src/sm_at_socket.h | Declares new function to notify socket module when data mode exits |
| app/src/sm_at_socket.c | Core implementation of automatic receive feature including mode tracking, event management, and the #XSOCKETMODE command handler |
| app/src/sm_at_host.h | Declares new in_at_mode() helper function |
| app/src/sm_at_host.c | Implements in_at_mode() function and adds notification call on data mode exit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trantanen
reviewed
Dec 1, 2025
MarkusLassila
force-pushed
the
add-socket-immediate
branch
from
c03e01b to
6ab7e1f
Compare
MarkusLassila
changed the title
MarkusLassila
force-pushed
the
add-socket-immediate
branch
6 times, most recently
from
3d4f261 to
b829cd3
Compare
Contributor
Author
|
Items from SM status meeting have been addressed. Feel free to review. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MarkusLassila
force-pushed
the
add-socket-immediate
branch
from
b829cd3 to
ea15f6d
Compare
trantanen
reviewed
Dec 4, 2025
trantanen
reviewed
Dec 4, 2025
divipillai
reviewed
Dec 4, 2025
MarkusLassila
commented
Dec 5, 2025
MarkusLassila
force-pushed
the
add-socket-immediate
branch
from
ea15f6d to
801c7e5
Compare
divipillai
approved these changes
Dec 5, 2025
MarkusLassila
force-pushed
the
add-socket-immediate
branch
2 times, most recently
from
908160c to
cd7656f
Compare
SeppoTakalo
reviewed
Dec 5, 2025
SeppoTakalo
approved these changes
Dec 8, 2025
MarkusLassila
force-pushed
the
add-socket-immediate
branch
from
cd7656f to
81bb08b
Compare
Contributor
Author
|
Ping @trantanen, @divipillai |
trantanen
approved these changes
Dec 8, 2025
divipillai
reviewed
Dec 8, 2025
A new AT-command #XRECVCFG can be used to set the automatic data reception for the sockets. When the automatic data reception is activated, the data received for the socket is immediately sent to host as URC. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
MarkusLassila
force-pushed
the
add-socket-immediate
branch
from
81bb08b to
c1fb5b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new AT-command #XRECVCFG can be used to set the automatic data reception for the sockets. When the automatic
data reception is activated, the data received for the socket is immediately sent to host as URC.
Jira: SM-110
Jira: SM-195