workflow: Create release assets#137
Conversation
jorgenmk
requested review from
Copilot and
trantanen
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR adds automated release asset creation to the GitHub release workflow. When a release is created, the workflow builds the serial modem application and uploads platform-specific binaries as release assets.
Changes:
- Added a new release workflow that triggers on release creation and builds release assets
- Modified the build workflow to support being called from the release workflow with conditional release artifact generation
- Added thingy91x platform to integration tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release.yaml | New workflow that orchestrates release asset creation by calling the build workflow and uploading artifacts to the release |
| .github/workflows/build.yml | Added workflow_call trigger and conditional steps to build and package release binaries for thingy91x and nrf9151dk platforms |
| app/sample.yaml | Added thingy91x platform to integration test platforms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if: ${{ inputs.trigger_source == 'release-workflow' }} | ||
| working-directory: serial_modem | ||
| run: | | ||
| VERSION=${{ github.event.release.tag_name || github.ref_name || 'unknown-version' }} |
There was a problem hiding this comment.
The github.event.release.tag_name context is not available in a reusable workflow called via workflow_call. The release event context only exists in the calling workflow. Consider passing the version as an input parameter to the reusable workflow instead.
| - name: Upload artifacts | ||
| if: ${{ inputs.trigger_source == 'release-workflow' }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: |
There was a problem hiding this comment.
The artifact upload is missing a name parameter. Without specifying a name, the artifact will be uploaded with a default name, which may not match the expected 'artifact/*' pattern used in the release.yaml download step (line 34). Add a name field such as name: artifact to ensure the download step can locate the uploaded files.
| with: | |
| with: | |
| name: artifact |
jorgenmk
force-pushed
the
add-release-assets
branch
4 times, most recently
from
93764ef to
c2b8aa0
Compare
jorgenmk
force-pushed
the
add-release-assets
branch
3 times, most recently
from
c081214 to
02133e3
Compare
trantanen
left a comment
trantanen
left a comment
There was a problem hiding this comment.
We are almost there...
jorgenmk
force-pushed
the
add-release-assets
branch
2 times, most recently
from
a9448ba to
3525507
Compare
Build and add release assets to release page in github. Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>
jorgenmk
force-pushed
the
add-release-assets
branch
from
3525507 to
fe488a6
Compare
Build and add release assets to release page in github.