app: Remove extra <CRLF> from AT response#182
Conversation
|
SM used to add <CRLF> between information text and the OK in AT responses when MFW returns one <CRLF> in there as follows: <CRLF>+COMMAND: RESPONSE,VALUE,OR,TEXT<CRLF><CRLF>OK<CRLF> Two <CRLF>s before OK will change to one: <CRLF>+COMMAND: RESPONSE,VALUE,OR,TEXT<CRLF>OK<CRLF> This should be aligned with 3GPP TS 27.007 Section 4.2. Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
trantanen
force-pushed
the
at_resp_crlf
branch
from
3295208 to
57c0bd5
Compare
| if (err) { | ||
| LOG_ERR("AT command response failed: %d", err); | ||
| } | ||
| err = sm_at_send_str(buf); |
There was a problem hiding this comment.
This works well for the AT+ and AT%, but the SM AT# commands still send the additional \r\n:
OK
Ready
at#xsocket=1,1,0
#XSOCKET: 0,1,6
OK
at+cereg?
+CEREG: 0,4
OK
The first \r\n comes from:
https://github.com/nrfconnect/ncs-serial-modem/blob/main/app/src/sm_at_socket.c#L542
And the second one from lines above this. The first one should be removed from all the commands.
|
I've looked at this and I guess there is some room for interpretation. The same standard doesn't have double line break in informative examples. But they are informative. |
|
It seems double CRLF before OK is done for specific requests from customers so we won't change it. |
3 participants
SM used to add
<CRLF>between information text and the OK in AT responses when MFW returns one<CRLF>in there as follows:<CRLF>+COMMAND: RESPONSE,VALUE,OR,TEXT<CRLF><CRLF>OK<CRLF>Two
<CRLF>s before OK will change to one:<CRLF>+COMMAND: RESPONSE,VALUE,OR,TEXT<CRLF>OK<CRLF>This should be aligned with 3GPP TS 27.007 Section 4.2.