Add TCP Listen and Accept#196
Merged
Merged
Conversation
MarkusLassila
requested review from
SeppoTakalo,
Copilot,
juhaylinen and
trantanen
There was a problem hiding this comment.
Pull request overview
Adds TCP server support to the Serial Modem AT socket layer by documenting and implementing AT#XLISTEN / AT#XACCEPT, plus extending AT#XSOCKET? output to include remote peer info for accepted sockets.
Changes:
- Extend
AT#XSOCKET?read response to optionally include accepted peer address/port. - Add
AT#XLISTEN(listen) andAT#XACCEPT(accept) AT commands in implementation and docs. - Update unit tests and test harness wiring (AT wrapper routing + kernel alloc stubs) to cover listen/accept behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| doc/app/at_socket.rst | Documents #XLISTEN / #XACCEPT and extends #XSOCKET? response format with peer info. |
| app/src/sm_at_socket.c | Implements listen/accept, tracks bound port + listen state, and stores peer address for accepted sockets. |
| app/tests/at_socket/src/nrf_modem_at_wrapper.c | Routes AT#XLISTEN / AT#XACCEPT to custom-command wrappers in tests. |
| app/tests/at_socket/src/test_at_socket.c | Adds tests for listen/accept and updates socket-count assumptions. |
| app/tests/at_socket/CMakeLists.txt | Links new kernel stubs into the at_socket test target. |
| app/tests/stubs/kernel_stubs.c | Provides k_malloc/k_free stubs for the unit-test environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trantanen
reviewed
Mar 2, 2026
Collaborator
trantanen
left a comment
trantanen
left a comment
There was a problem hiding this comment.
Going through doc and parts of code.
SeppoTakalo
reviewed
Mar 4, 2026
MarkusLassila
force-pushed
the
tcp-listen-accept
branch
3 times, most recently
from
ac3bea8 to
67ca2cf
Compare
MarkusLassila
force-pushed
the
tcp-listen-accept
branch
3 times, most recently
from
b323581 to
917689c
Compare
Contributor
Author
|
@divipillai: Adding missing migration guide still |
MarkusLassila
force-pushed
the
tcp-listen-accept
branch
from
917689c to
a21d44b
Compare
Contributor
Author
|
@divipillai, migration guide added, feel free to review. |
trantanen
reviewed
Mar 11, 2026
divipillai
reviewed
Mar 11, 2026
MarkusLassila
force-pushed
the
tcp-listen-accept
branch
4 times, most recently
from
10159f9 to
caa864a
Compare
divipillai
approved these changes
Mar 12, 2026
MarkusLassila
force-pushed
the
tcp-listen-accept
branch
from
caa864a to
b664283
Compare
Add AT#XLISTEN and AT#XACCEPT for TCP server functionality. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
Basic unit tests for AT#XLISTEN and AT#XACCEPT. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
MarkusLassila
force-pushed
the
tcp-listen-accept
branch
from
b664283 to
c10df75
Compare
trantanen
approved these changes
Mar 12, 2026
Collaborator
trantanen
left a comment
trantanen
left a comment
There was a problem hiding this comment.
Great to have this back 😄
Comment on lines
+974
to
+975
| __cmock_nrf_accept_Stub(mock_nrf_accept_with_peer_callback); | ||
| __cmock_zsock_inet_ntop_Stub(mock_zsock_inet_ntop_192_168_0_100_callback); |
Collaborator
There was a problem hiding this comment.
I don't know if there is a reason why CMockReturnMemThruPtr wouldn't work here?
You can also skip this here now. I think we have places where we could probably use it more.
SeppoTakalo
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AT#XLISTEN and AT#XACCEPT for TCP server functionality.
Jira: SM-240