app: Add runtime safety checks for AT host#223
Merged
Conversation
trantanen
approved these changes
Mar 19, 2026
MarkusLassila
approved these changes
Mar 20, 2026
juhaylinen
approved these changes
Mar 20, 2026
Various functions like: * check_idle_timer() * in_at_mode_*() * is_idle_*() * is_open_*() are designed to tolerate NULL for either context or pipe pointer. This is because sm_at_host_get_current(), sm_at_host_get_pipe() and sm_at_host_get_current_pipe() are designed to return NULL when there is no context or pipe to point to. However, few of those mentioned were not properly handling the NULL, especially the internal check_idle_timer() caused NULL pointer dereference if context was destroyed just before URC message was send to that pipe. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
SeppoTakalo
force-pushed
the
pipe_null_checks
branch
from
fa8eb2f to
bc3a662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various functions like:
are designed to tolerate NULL for either context or pipe pointer. This is because sm_at_host_get_current(), sm_at_host_get_pipe() and sm_at_host_get_current_pipe() are designed to return NULL when there is no context or pipe to point to.
However, few of those mentioned were not properly handling the NULL, especially the internal check_idle_timer() caused NULL pointer dereference if context was destroyed just before URC message was send to that pipe.