Fix unnecessary PPP pipe release on Linux+CMUX case#226
Merged
Conversation
The idle timer is not necessary enough to detect whether AT command is still progressing, so add an extra flag for that. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
On the AT#XPPP=0, we should still keep the pipe on certain cases. Mostly, when PPP is running on DLC 2. So leave the channel release to AT+CGDATA command, or CMUX module. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
MarkusLassila
approved these changes
Mar 23, 2026
Contributor
Would categorize this as major issue though. |
trantanen
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue SM-273 where PPP pipe was released when
AT#XPPP=0was issued, and followed byAT#XPPP=1.This was a regression caused by #224
Another minor issue found when
urc_send_to()is used while AT command is executing longer than 1s.This causes URC messages to enter the pipe before
OK