fix: the sms response buffer handling in sm_at_sms in sm_at_sms.c#294
Open
orbisai0security wants to merge 1 commit into
Open
fix: the sms response buffer handling in sm_at_sms in sm_at_sms.c#294orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
app/src/sm_at_sms.c.Vulnerability
V-001app/src/sm_at_sms.c:127Description: The SMS response buffer handling in sm_at_sms.c uses unbounded sprintf() at line 127, strcpy() at line 137, and strcat() at line 149 to write into sms_ctx.concat_rsp_buf without any bounds checking. An attacker who can send an oversized SMS message payload can overflow the buffer, corrupting adjacent stack or heap memory. The three consecutive unsafe operations compound the overflow risk significantly.
Changes
app/src/sm_at_sms.cVerification
Automated security fix by OrbisAI Security