Skip to content

WIP: Modem fixes from upstream Zephyr #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SeppoTakalo wants to merge 2 commits into from
Closed

WIP: Modem fixes from upstream Zephyr #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d7da57
manifest: Build against a PR that contains upstream modem fixes
SeppoTakalo May 12, 2026
a95bba5
app: Refactor nrf_cloud_rest to nrf_cloud_coap
SeppoTakalo May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/src/sm_at_gnss.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,8 @@ static void agnss_requestor(struct k_work *)
int err;
struct nrf_modem_gnss_agnss_data_frame req;
static char agnss_rest_data_buf[NRF_CLOUD_AGNSS_MAX_DATA_SIZE];
struct nrf_cloud_rest_agnss_request request = {
NRF_CLOUD_REST_AGNSS_REQ_CUSTOM,
struct nrf_cloud_coap_agnss_request request = {
NRF_CLOUD_COAP_AGNSS_REQ_CUSTOM,
&req,
};

Expand All @@ -332,7 +332,7 @@ static void agnss_requestor(struct k_work *)
return;
}

struct nrf_cloud_rest_agnss_result result = {agnss_rest_data_buf,
struct nrf_cloud_coap_agnss_result result = {agnss_rest_data_buf,
sizeof(agnss_rest_data_buf), 0};
struct lte_lc_cells_info net_info = {0};

Expand All @@ -345,7 +345,7 @@ static void agnss_requestor(struct k_work *)

err = nrf_cloud_coap_agnss_data_get(&request, &result);
if (err) {
LOG_ERR("Failed to request A-GNSS data via REST (%d).", err);
LOG_ERR("Failed to request A-GNSS data via CoAP (%d).", err);
return;
}

Expand Down Expand Up @@ -375,7 +375,7 @@ static void pgps_requestor(struct k_work *)
static void pgps_coap_requestor(struct k_work *)
{
int err;
struct nrf_cloud_rest_pgps_request request = {.pgps_req = &pgps_coap_request};
struct nrf_cloud_coap_pgps_request request = {.pgps_req = &pgps_coap_request};
struct nrf_cloud_pgps_result file_location = {0};
static char host[64];
static char path[128];
Expand Down
2 changes: 1 addition & 1 deletion app/src/sm_at_nrfcloud.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ static void loc_req_wk(struct k_work *work)
}

struct nrf_cloud_location_result result = {0};
const struct nrf_cloud_rest_location_request request = {
const struct nrf_cloud_coap_location_request request = {
.config = NULL,
.cell_info = nrfcloud_cell_pos ? &nrfcloud_cell_data : NULL,
.wifi_info = nrfcloud_wifi_pos ? &nrfcloud_wifi_data : NULL};
Expand Down
11 changes: 11 additions & 0 deletions submanifests/00-upstream-fixes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Copyright (c) 2026 Nordic Semiconductor
# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause

# Build against a PR that contains upstream modem fixes

manifest:
projects:
- name: nrf
url: https://github.com/nrfconnect/sdk-nrf.git
revision: pull/28730/head
import: true
Loading