Use current addrinfo entry in #XGETADDRINFO result iteration#318
Closed
Copilot wants to merge 2 commits into
Closed
Use current addrinfo entry in #XGETADDRINFO result iteration#318Copilot wants to merge 2 commits into
#XGETADDRINFO result iteration#318Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Use current addrinfo entry in May 22, 2026
#XGETADDRINFO result iteration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewed issue pointed out that
AT#XGETADDRINFOiteratedaddrinforesults but readresult->ai_addr(head node) instead of the current loop node, which can return incorrect addresses when multiple DNS results are present.This update scopes to that comment and aligns address selection with the active iterator entry.
AT#XGETADDRINFOaddress selectionhandle_at_getaddrinfo(), switched IPv4/IPv6 address casts fromresult->ai_addrtores->ai_addrinside the result loop.addrinfonode.Regression coverage for multi-result iteration
AT#XGETADDRINFOwith multiple mocked IPv4 results.