Fix DTS problems#338
Merged
Merged
Conversation
Additional partition needs to be inside storage_partition so that TF-M sets it non-secure. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
- Add missing b0 and mcuboot overlays - Set the secure size correctly for overlay-trace-backend.overlay - Disable carrier for Thingy:91x. It would need it's own overlay as the storage_partition is in external flash. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
There was a problem hiding this comment.
Pull request overview
This PR updates devicetree overlays to resolve build/validation issues across sysbuild (MCUboot/B0) and feature overlays, particularly for the Thingy:91 X (nRF9151) and for flash/RAM layout overlays used by optional features.
Changes:
- Add/align Thingy:91 X sysbuild overlays (MCUboot + B0) to set
zephyr,code-partition, useuart1console, and configure UART1 baudrate. - Adjust trace-backend SRAM overlay to delete/recreate
sram0_s/sram0_nsnodes explicitly. - Rework PGPS and Memfault flash overlays to introduce a
storage_partitioncontainer with sub-partitions (and select a settings partition), and narrow one Twister build matrix entry to DK only.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/sysbuild/mcuboot/boards/thingy91x_nrf9151.overlay | Adds chosen nodes for MCUboot and switches console/UART config to uart1 at 1M baud. |
| app/sysbuild/b0/boards/thingy91x_nrf9151.overlay | New Thingy:91 X B0 sysbuild overlay setting code partition + console on uart1. |
| app/sample.yaml | Removes Thingy:91 X from the serial_modem.lwm2m_carrier test’s platform_allow. |
| app/overlay-trace-backend.overlay | Makes SRAM node layout explicit by deleting and recreating secure/non-secure SRAM nodes. |
| app/overlay-pgps.overlay | Refactors flash layout to use a storage_partition with pgps + settings-storage sub-partitions. |
| app/overlay-memfault.overlay | Refactors flash layout to use a storage_partition with Memfault coredump + settings-storage sub-partitions. |
trantanen
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing leftovers found by CI in PM to DTS transition related to Thingy91:X, Memfault and P-GPS.
Jira: SM-244