app: Rename AT#XGPS to AT#XGNSS#7
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the AT command from AT#XGPS to AT#XGNSS to better reflect that it controls GNSS (Global Navigation Satellite System) functionality rather than just GPS specifically.
- Updates AT command names from
#XGPS/#XGPSDELto#XGNSS/#XGNSSDEL - Updates documentation and code comments to reflect the new naming convention
- Updates response messages and examples throughout documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/app/Generic_AT_commands.rst | Updates command list example to show AT#XGNSS instead of AT#XGPS |
| doc/app/GNSS_AT_commands.rst | Comprehensive update of all documentation examples, syntax descriptions, and command references from GPS to GNSS naming |
| app/src/gnss/sm_at_gnss.c | Updates AT command registration, response messages, and code comments to use GNSS naming convention |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
trantanen
left a comment
trantanen
left a comment
There was a problem hiding this comment.
Let's add migration guide entry.
The guide doesn't exist yet so I'm holding the PR from being merged with this comment for now. I will let you know when you can add an entry there.
|
@moksanen, @jvaliharju |
tokangas
left a comment
tokangas
left a comment
There was a problem hiding this comment.
Looks good to me, only a few suggestions for consistency.
I couldn't add a comment on line 780, but this comment could be updated as well (GPS -> GNSS):
An old value might otherwise remain from a previous GPS run.
juhaylinen
force-pushed
the
rename_xgps_to_xgnss
branch
2 times, most recently
from
a9e9fa6 to
2e5cd6f
Compare
Base for the migration guide has been now added (doc/app/sm_migration.rst) so you can create an entry there for this change. |
Rename AT commands and update documentation. Add entry to the migration guide. Jira: SLM-127 Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>
juhaylinen
force-pushed
the
rename_xgps_to_xgnss
branch
from
2e5cd6f to
40812e1
Compare
|
@juhaylinen Do you have merge rights for this? You should have them. |
Yes, I can merge this. Should I press the button? |
Yes. |
Jira: SLM-127