samples: Add shell sample for PPP modem driver#86
Conversation
SeppoTakalo
force-pushed
the
zephyr_modem_example
branch
4 times, most recently
from
803dc3b to
2a9010c
Compare
trantanen
left a comment
trantanen
left a comment
There was a problem hiding this comment.
Thanks for putting this together. If you don't have time to fix nit-picking, I can handle that too.
MarkusLassila
left a comment
MarkusLassila
left a comment
There was a problem hiding this comment.
Tried out with the native_sim, that complained about missing xterm, but it was not highlighted: sh: 1: xterm: not found
After adding xterm everything worked fine. 👍
Not something to address, but mentioning this in case we get complaints about this not working as it was bit difficult to spot.
The commands should be mentioned in the documentation. |
SeppoTakalo
force-pushed
the
zephyr_modem_example
branch
3 times, most recently
from
e5ec9ab to
fbecbef
Compare
SeppoTakalo
force-pushed
the
zephyr_modem_example
branch
from
fbecbef to
8ff9598
Compare
SeppoTakalo
force-pushed
the
zephyr_modem_example
branch
2 times, most recently
from
bf8a78f to
f821dc5
Compare
trantanen
left a comment
trantanen
left a comment
There was a problem hiding this comment.
Great to have this sample! Especially the native_sim part is nice and also documentation becomes nice with the general samples/README.rst.
| CONFIG_MODEM_LOG_LEVEL_DBG=y | ||
| CONFIG_MODEM_CMUX_LOG_LEVEL_DBG=y |
There was a problem hiding this comment.
Do we want these on by default? Is it a lot of spam?
There was a problem hiding this comment.
True, it spams a bit, but not after the network is up and running.
Without these, it is impossible to see when device enters or exists the sleep mode, or when the modem driver starts up.
There was a problem hiding this comment.
I'll leave the decision to you and @MarkusLassila
There was a problem hiding this comment.
I don't mind the CMUX logs in here. This may be the first point people run into CMUX, so showing them in here might even have a positive effect.
SeppoTakalo
force-pushed
the
zephyr_modem_example
branch
2 times, most recently
from
493b0bb to
c105d95
Compare
MarkusLassila
left a comment
MarkusLassila
left a comment
There was a problem hiding this comment.
Looks good. Some comments.
|
|
||
| west build -b nrf54l15dk/nrf54l15/cpuapp | ||
|
|
||
| For the TrustZone-enabled variant: |
There was a problem hiding this comment.
Should this refer to Trusted Firmware-M?
| CONFIG_MODEM_LOG_LEVEL_DBG=y | ||
| CONFIG_MODEM_CMUX_LOG_LEVEL_DBG=y |
There was a problem hiding this comment.
I don't mind the CMUX logs in here. This may be the first point people run into CMUX, so showing them in here might even have a positive effect.
Add Zephyr shell sample that uses PPP modem driver from Zephyr and allows debugging the network connection from shell commands. Example configurations provided for native_sim and nRF54L15DK. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
SeppoTakalo
force-pushed
the
zephyr_modem_example
branch
from
c105d95 to
8172786
Compare
Add documentation for PPP modem shell sample and move sample descriptions to own index page. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
SeppoTakalo
force-pushed
the
zephyr_modem_example
branch
from
8172786 to
2555dde
Compare
divipillai
left a comment
divipillai
left a comment
There was a problem hiding this comment.
I had some comments on the docs and image needs to follow the Nordic guidelines. Since the PR is already merge, I will create a new PR to fix those.
Sorry.. I might have been too quick on merging this as I have been waiting for few weeks to complete it. |
4 participants
Add Zephyr shell sample that uses PPP modem driver from Zephyr and allows debugging the network connection from shell commands.
Example configurations provided for native_sim and nRF54L15DK.
Commands that can be used:
net iface up 1net iface down 1net dnsnet dns <HOST>net ping <IP>zperf tcp upload <IP> <PORT> <DURATION> <PAYLOAD_SIZE>Example:
zperf tcp upload 212.237.217.41 5202 1 1KJira: SM-178