[nrf noup] Use ZAP CLI for version check#600
Merged
Merged
Conversation
|
none Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
Damian-Nordic
approved these changes
Apr 24, 2025
Contributor
Damian-Nordic
left a comment
Damian-Nordic
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I agree it makes sense.
Contributor
Author
|
Do I need to open a manifest PR in |
Member
|
Hi @kendallgoto, you have to sign Contributor License Agreement before we can merge this. Please force push to this PR (and #601) to trigger the CLAassistant. |
Both `zap --version` and `zap-cli --version` do the same thing more or less, but `zap` is heavier to run since it starts Electron just to do `--version`. Since the user may only care about `zap-cli` commands (e.g. `west zap-generate`), requiring that all `west zap-*` commands call `zap` just to get a version check increases the amount of resources and dependencies required Signed-off-by: Kendall Goto <kendall@level.co>
ArekBalysNordic
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
zap --versionandzap-cli --versiondo the same thing more or less, butzapis heavier to run since it starts Electron just to do--version. Since the user may only care aboutzap-clicommands (e.g.west zap-generate), requiring that allwest zap-*commands callzapjust to get a version check increases the amount of resources and dependencies required.Instead, just use
zap-clito get the version.