[nrf toup][nrfconnect] Align OpenThread Kconfigs with Zephyr changes#611
Merged
Conversation
github-actions
Bot
added
examples
config
platform
nrf connect
zephyr
test driver
labels
Damian-Nordic
approved these changes
May 16, 2025
| @@ -314,7 +314,7 @@ config CHIP_IPV4 | |||
| config CHIP_OPENTHREAD_JOINER_ENABLED | |||
| bool "Specify whether the Thread Joiner functionality is used when it is enabled" | |||
Contributor
There was a problem hiding this comment.
Is this config still used for anything?
Member
Author
There was a problem hiding this comment.
Looks like it's no longer used, I will remove it.
| # Zephyr networking configuration | ||
| # ============================================================================== | ||
|
|
||
| if CONFIG_NETWORKING |
Contributor
There was a problem hiding this comment.
Suggested change
| if CONFIG_NETWORKING | |
| if NETWORKING |
Damian-Nordic
approved these changes
May 16, 2025
LuDuda
approved these changes
May 16, 2025
| with IPv4 support independently of the Matter stack still | ||
| running over IPv6. | ||
|
|
||
| config CHIP_OPENTHREAD_JOINER_ENABLED |
| config IEEE802154_NRF5_RX_STACK_SIZE | ||
| default 1024 | ||
|
|
||
| endif # NET_L2_OPENTHREAD |
Collaborator
There was a problem hiding this comment.
Should we change line 271:
default y if !WIFI_NRF70
to
default y if OPENTHREAD
Member
Author
There was a problem hiding this comment.
Currently OPENTHREAD is selected by NET_L2_OPENTHREAD so no.
We can change this when we switch to the new radio implementation.
| matter_add_gn_arg_bool("chip_detail_logging" CONFIG_MATTER_LOG_LEVEL GREATER_EQUAL 4) | ||
| matter_add_gn_arg_bool("chip_automation_logging" FALSE) | ||
| matter_add_gn_arg_bool("chip_enable_openthread" CONFIG_NET_L2_OPENTHREAD) | ||
| matter_add_gn_arg_bool("chip_enable_openthread" CONFIG_OPENTHREAD) |
Collaborator
There was a problem hiding this comment.
It will take some time after we would be able to upstream it I guess (due to TLink or others)..
Member
Author
There was a problem hiding this comment.
It should work the same, as NET_L2_OPENTHREAD selects OPENTHREAD.
Replace `NET_L2_OPENTHREAD` with `OPENTHREAD` as OpenThread Kconfigs were moved from L2 to OpenThread module. Keep `NET_L2_OPENTHREAD` if there is dependency to networking. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Remove CHIP_OPENTHREAD_JOINER_ENABLED Kconfig as it's no longer used. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
NET_L2_OPENTHREADwithOPENTHREADas OpenThread Kconfigs were moved from L2 to OpenThread module.Keep
NET_L2_OPENTHREADif there is dependency to networking.manifest-pr-skip
NCS PR: nrfconnect/sdk-nrf/pull/22366