[config] Fixed gn parser implementation#721
Merged
Merged
Conversation
kkasperczyk-no
force-pushed
the
gn_parser_fix
branch
from
b45d44e to
027a739
Compare
NordicBuilder
added a commit
to NordicBuilder/sdk-nrf
that referenced
this pull request
May 21, 2026
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#721 Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
LuDuda
approved these changes
May 21, 2026
The make_gn_args.py read args.tmp and uses argparse that treats any line starting with - as an option, not as a positional value for --arg-cflags. When including only a single -D option, for example in TF-M builds that only export -DTF_PSA_CRYPTO_CONFIG_FILE=... on target_cflags, the parser fails with argument --arg-cflags: expected 2 arguments Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
kkasperczyk-no
force-pushed
the
gn_parser_fix
branch
from
027a739 to
62cc597
Compare
NordicBuilder
added a commit
to NordicBuilder/sdk-nrf
that referenced
this pull request
May 21, 2026
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#721 Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder
added a commit
to NordicBuilder/sdk-nrf
that referenced
this pull request
May 21, 2026
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#721 Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
nordicjm
pushed a commit
to nrfconnect/sdk-nrf
that referenced
this pull request
May 21, 2026
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#721 Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The make_gn_args.py read args.tmp and uses argparse that treats any line starting with - as an option, not as a positional value for --arg-cflags.
When including only a single -D option, for example in TF-M builds that only export -DTF_PSA_CRYPTO_CONFIG_FILE=... on target_cflags, the parser fails with argument --arg-cflags: expected 2 arguments
Testing
Automated testing in CI