[nrf noup] bootutil: Fix ITS key locking compile error #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchy
approved these changes
Oct 31, 2025
tomchy
reviewed
Oct 31, 2025
| #endif /* CONFIG_BOOT_KMU_KEYS_REVOCATION */ | ||
|
|
||
| #if defined(CONFIG_BOOT_SIGNATURE_USING_KMU) | ||
| void nrf_crypto_keys_housekeeping(void) |
Contributor
There was a problem hiding this comment.
Wait. Is there a code that prevents us from calling nrf_crypto_keys_housekeeping?
Contributor
Author
There was a problem hiding this comment.
You do not need to worry in this matter, see:
nrf_crypto_keys_housekeeping will be defined as do {} while(0); if CONFIG_BOOT_SIGNATURE_USING_KMU is not set
de-nordic
approved these changes
Oct 31, 2025
nrf-squash! [nrf noup] bootutil: Locking KMU keys KMU key locking is not available in case ITS is used. Old code cause compilation errors when build for signature using ITS. Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
force-pushed
the
NCSDK-35179_no_houskeeping_its
branch
from
ce911d0 to
f018672
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrf-squash! [nrf noup] bootutil: Locking KMU keys
KMU key locking is not available in case ITS is used. Old code cause compilation errors when build for signature using ITS.