lib: add ble_radio_notification and sample by eivindj-nordic · Pull Request #351 · nrfconnect/sdk-nrf-bm

eivindj-nordic · 2025-09-02T08:54:37Z

Add ble_radio_notification library and sample.

github-actions · 2025-09-02T08:55:46Z

You can find the documentation preview for this PR here.

nordicjm · 2025-09-04T10:33:17Z

 /tests/lib/bm_zms/                        @nrfconnect/ncs-bm @rghaddab
 /tests/lib/ble_qwr/                       @nrfconnect/ncs-bm
 /tests/lib/ble_racp/                      @nrfconnect/ncs-bm
+/tests/lib/ble_radio_notif/                @nrfconnect/ncs-bm


alignment is off

nordicjm · 2025-09-04T10:35:08Z

+#define STATIC static
+#endif
+
+LOG_MODULE_REGISTER(ble_radio_ntf, CONFIG_BLE_RADIO_NTF_LOG_LEVEL);


Suggested change

LOG_MODULE_REGISTER(ble_radio_ntf, CONFIG_BLE_RADIO_NTF_LOG_LEVEL);

LOG_MODULE_REGISTER(ble_radio_notification, CONFIG_BLE_RADIO_NOTIFICATION_LOG_LEVEL);

nordicjm · 2025-09-04T10:35:24Z

+	   IRQ Priority level 0 and 4 are reserved by the SoftDevice.
+
+
+module=BLE_RADIO_NTF


Suggested change

module=BLE_RADIO_NTF

module=BLE_RADIO_NOTIFICATION

nordicjm · 2025-09-04T10:36:12Z

+	range 50 5500
+	default 800
+
+module=BLE_RADIO_NTF_SAMPLE


fix names as above

nordicjm · 2025-09-04T10:36:50Z

+void setUp(void)
+{
+}
+void tearDown(void)
+{
+}
+


Suggested change

void setUp(void)

{

}

void tearDown(void)

{

}

lemrey · 2025-09-04T12:46:34Z

+/* Application event handler for handling Radio Notification events. */
+static ble_radio_notification_evt_handler_t evt_handler;
+
+STATIC void radio_notification_isr(const void *arg)


why are we using STATIC here?

Se definition above. It is to be able to call the event handler from the unit test.

lemrey · 2025-09-04T12:47:12Z

+	}
+}
+
+uint32_t ble_radio_notification_init(uint32_t distance,


Not when we are returning nrf_error.

lemrey · 2025-09-04T12:49:20Z

+	type = NRF_RADIO_NOTIFICATION_TYPE_INT_ON_INACTIVE;
+#endif
+
+	evt_handler = _evt_handler;


Should the user be able to unset the callback? If not, we could check against NULL here, and avoid doing at every interrupt before invoking the callback. Otherwise, If it should be possible to unset the callback, we could provide an explicit de-initialization function

Ok, will move the check for evt_handler to the initialization. I don't think having a callback-unset would provide much value, unless that is also disabling the IRQ. Though, in that case, if disabling while the radio is active, the radio active state might be messed up.

lemrey · 2025-09-04T12:59:00Z

+#if defined CONFIG_BLE_RADIO_NOTIFICATION_ON_BOTH
+	radio_active = !radio_active;
+#endif


nit: I would use the macro IS_ENABLED() here

We don't do that anywhere else, only for runtime if's.

eivindj-nordic · 2025-09-29T07:40:04Z

@nordicjm Please have another look.

MirkoCovizzi · 2025-10-01T08:22:37Z

+#
+# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
+#
+menuconfig BLE_RADIO_NOTIFICATION


I just realized that this is not expressing the dependency on SoftDevice.

Added. Note that this applies for most of the bluetooth libraries. So we should clean it up.

@eivindj-nordic What do you mean?

We do not have this dependency for many of the other ble libraries. See connection parameters etc.

anhmolt

Approving, but please address comments.

eivindj-nordic · 2025-10-06T08:14:44Z

@nordicjm Please have another look.

lemrey · 2025-10-17T11:34:49Z

+
+#include <stdint.h>
+#include <stdbool.h>
+#include <nrf_soc.h>


It seems this is not needed here

Moved to c-file.

lemrey · 2025-10-17T11:38:02Z

+CONFIG_LOG_BACKEND_BM_UARTE=y
+
+CONFIG_SOFTDEVICE=y
+CONFIG_NRF_SDH=y


just CONFIG_SOFTDEVICE should work now

lemrey · 2025-10-17T11:38:13Z

+CONFIG_BLE_ADV_FAST_ADVERTISING_INTERVAL=400
+CONFIG_BLE_ADV_SLOW_ADVERTISING_INTERVAL=1600


Do we need to override defaults here?

Strictly no, though it makes it more observable by looking at the LED. With default intervals it blinks quite fast regardless of the advertising mode.

lemrey · 2025-10-17T11:39:16Z

+  NRF54L15_XXAA
+  CONFIG_BLE_RADIO_NOTIFICATION_ON_BOTH=1
+  CONFIG_BLE_RADIO_NOTIFICATION_IRQ_PRIO=5
+  SWI02_IRQn=0


uhm why SWI02_IRQn=0 (equal zero?)

Just needed to be defined to something, updated to 30 as is what it is defined to for nRF54l15.

eivindj-nordic · 2025-10-29T08:47:51Z

@nordicjm @nrfconnect/ncs-bm-doc Please review!

Add ble_radio_notification library and sample. Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>

eivindj-nordic added this to the v0.9.0 milestone Sep 2, 2025

eivindj-nordic requested a review from vegardgu September 2, 2025 08:54

eivindj-nordic self-assigned this Sep 2, 2025

eivindj-nordic requested review from a team as code owners September 2, 2025 08:54

github-actions Bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Sep 2, 2025

eivindj-nordic force-pushed the radio_notif branch from 74df57c to 2f5eb93 Compare September 2, 2025 08:55

eivindj-nordic force-pushed the radio_notif branch from 2f5eb93 to e110194 Compare September 2, 2025 08:59

eivindj-nordic requested a review from a team as a code owner September 2, 2025 08:59

github-actions Bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 2, 2025

eivindj-nordic force-pushed the radio_notif branch from e110194 to afdbe0a Compare September 2, 2025 10:08

vegardgu reviewed Sep 2, 2025

View reviewed changes

eivindj-nordic force-pushed the radio_notif branch 4 times, most recently from 8c2a381 to 974e8c4 Compare September 2, 2025 14:22

vegardgu approved these changes Sep 3, 2025

View reviewed changes

eivindj-nordic force-pushed the radio_notif branch from 974e8c4 to 15c45c2 Compare September 3, 2025 06:34

nordicjm requested changes Sep 4, 2025

View reviewed changes

eivindj-nordic force-pushed the radio_notif branch from 15c45c2 to cf7859c Compare September 4, 2025 10:56

lemrey reviewed Sep 5, 2025

View reviewed changes

eivindj-nordic force-pushed the radio_notif branch from cf7859c to a448920 Compare September 8, 2025 07:08

eivindj-nordic removed this from the v0.9.0 milestone Sep 18, 2025

eivindj-nordic force-pushed the radio_notif branch from a448920 to 45f9ef4 Compare September 19, 2025 11:39

eivindj-nordic added this to the v1.0.0 milestone Sep 26, 2025

eivindj-nordic force-pushed the radio_notif branch from 45f9ef4 to 93ae69f Compare September 26, 2025 13:22

eivindj-nordic requested review from MirkoCovizzi and nordicjm October 1, 2025 07:42

MirkoCovizzi reviewed Oct 1, 2025

View reviewed changes

eivindj-nordic force-pushed the radio_notif branch 6 times, most recently from 137e477 to a34885f Compare October 3, 2025 07:18

eivindj-nordic requested a review from MirkoCovizzi October 3, 2025 10:32

eivindj-nordic force-pushed the radio_notif branch 2 times, most recently from fe2b67f to ba0b865 Compare October 3, 2025 11:56

anhmolt approved these changes Oct 3, 2025

View reviewed changes

Comment thread doc/nrf-bm/libraries/ble_radio_notification.rst Outdated

Comment thread include/ble_radio_notification.h Outdated

Comment thread samples/bluetooth/ble_radio_notification/src/main.c Outdated

Comment thread include/bm/bluetooth/ble_radio_notification.h

eivindj-nordic force-pushed the radio_notif branch from ba0b865 to bad6849 Compare October 3, 2025 13:05

eivindj-nordic force-pushed the radio_notif branch from bad6849 to aa43dd2 Compare October 6, 2025 10:52

lemrey reviewed Oct 17, 2025

View reviewed changes

eivindj-nordic force-pushed the radio_notif branch 3 times, most recently from 8cc6735 to e6dd6fd Compare October 21, 2025 12:51

eivindj-nordic requested a review from lemrey October 22, 2025 06:28

nordicjm approved these changes Oct 29, 2025

View reviewed changes

b-gent force-pushed the radio_notif branch from e6dd6fd to 1413262 Compare October 29, 2025 23:09

b-gent approved these changes Oct 29, 2025

View reviewed changes

b-gent force-pushed the radio_notif branch from 1413262 to 4a5b190 Compare October 29, 2025 23:18

lib: add ble_radio_notification and sample

570b607

Add ble_radio_notification library and sample. Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>

eivindj-nordic force-pushed the radio_notif branch from 4a5b190 to 570b607 Compare November 3, 2025 12:27

eivindj-nordic merged commit 3571470 into nrfconnect:main Nov 5, 2025
10 checks passed

eivindj-nordic deleted the radio_notif branch November 5, 2025 12:59

	LOG_MODULE_REGISTER(ble_radio_ntf, CONFIG_BLE_RADIO_NTF_LOG_LEVEL);
	LOG_MODULE_REGISTER(ble_radio_notification, CONFIG_BLE_RADIO_NOTIFICATION_LOG_LEVEL);

		IRQ Priority level 0 and 4 are reserved by the SoftDevice.


		module=BLE_RADIO_NTF

		CONFIG_BLE_ADV_FAST_ADVERTISING_INTERVAL=400
		CONFIG_BLE_ADV_SLOW_ADVERTISING_INTERVAL=1600

Conversation

eivindj-nordic commented Sep 2, 2025

Uh oh!

github-actions Bot commented Sep 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eivindj-nordic commented Sep 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anhmolt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eivindj-nordic commented Oct 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!