tests: unit: bluetooth: ble_lbs: add tests#764
Open
lemrey wants to merge 1 commit into
Open
Conversation
|
You can find the documentation preview for this PR here. |
eivindj-nordic
approved these changes
Apr 28, 2026
Comment on lines
+194
to
+200
| /* Success path with full validation of arguments to SoftDevice calls. */ | ||
| __cmock_sd_ble_uuid_vs_add_Stub(stub_sd_ble_uuid_vs_add_success); | ||
| __cmock_sd_ble_gatts_service_add_Stub(stub_sd_ble_gatts_service_add_success); | ||
| __cmock_sd_ble_gatts_characteristic_add_Stub(stub_sd_ble_gatts_characteristic_add_success); | ||
|
|
||
| nrf_err = ble_lbs_init(&ble_lbs, &cfg); | ||
| TEST_ASSERT_EQUAL(NRF_SUCCESS, nrf_err); |
Contributor
There was a problem hiding this comment.
This should be split out.
| TEST_ASSERT_EQUAL(ERROR, nrf_err); | ||
| } | ||
|
|
||
| void test_ble_bls_init(void) |
anhmolt
approved these changes
Apr 29, 2026
Comment on lines
+6
to
+9
| # Redefine Kconfigs used by the tested module that are defined in | ||
| # other modules we do not want to enable. | ||
| config NRF_SDH_BLE_TOTAL_LINK_COUNT | ||
| default 1 |
Contributor
There was a problem hiding this comment.
This does not seem to be needed for this test.
| #include <unity.h> | ||
|
|
||
| #include <ble.h> | ||
| #include <ble_err.h> |
Contributor
There was a problem hiding this comment.
ble_err.h header seems to not be needed.
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
Add unit tests for ble_lbs. Signed-off-by: Emanuele Di Santo <emdi@nordicsemi.no>
github-actions
Bot
added
the
changelog-entry-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit test suite for
ble_lbs.Depends on #747 , ignore first few commits.