lib: bluetooth: scan: Make name and address filter const#791
Merged
Conversation
github-actions
Bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
Contributor
|
You can add release notes here: https://github.com/nrfconnect/sdk-nrf-bm/blob/main/doc/nrf-bm/release_notes/release_notes_changelog.rst |
github-actions
Bot
added
doc-required
- Make name_filter in struct ble_scan_filter_data const - Make addr_filter in struct ble_scan_filter_data const Signed-off-by: Asil Zogby <asil.zogby@nordicsemi.no>
asilz
changed the title
eivindj-nordic
approved these changes
May 11, 2026
lemrey
approved these changes
May 12, 2026
b-gent
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the name and address filter members in the
ble_scan_filter_datastruct are notconsteven though they are never modified in the scan library. I think the API should guarantee that they are not modified since I do not see a reason for why we want to modify in the library