lib: bluetooth: peer_manager: LESC DHkey computation request fixes - #857
Merged
eivindj-nordic merged 2 commits intoSep 22, 2026
Merged
Conversation
Treat invalid connection handle as success when replying with a dhkey to the SoftDevice. Error BLE_ERROR_INVALID_CONN_HANDLE is only returned from sd_ble_gap_lesc_dhkey_reply() in the compute_and_give_dhkey() function if the peer disconnected while computing the DH key. In this case, the DH key is no longer of any value and nrf_ble_lesc_request_handler() function have succeeded. Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>
Synchronize access to the DHkey computation requested state to avoid some theoretical race conditions between nrf_ble_lesc_request_handler() called from main context and nrf_ble_lesc_on_ble_evt() called from interrupt context. Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>
github-actions
Bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
Contributor
Author
let us skip that here. Most changes are internal. The first commit (1a30bc2) touches the API of |
anhmolt
removed
the
changelog-entry-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nrf_ble_lesc_request_handler()called from main context andnrf_ble_lesc_on_ble_evt()called from interrupt context.