Skip to content

Conversation

@gmarull
Copy link
Member

@gmarull gmarull commented Sep 10, 2024

No description provided.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. labels Sep 10, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 10, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@8fa4251 nrfconnect/sdk-nrfxlib@39e1163 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 10, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 13

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@gmarull gmarull force-pushed the drop-all-breathe branch 5 times, most recently from 098430f to 9f8898f Compare September 10, 2024 15:04
@gmarull gmarull marked this pull request as ready for review September 10, 2024 15:25
bjarki-andreasen pushed a commit to bjarki-andreasen/sdk-nrf that referenced this pull request Sep 25, 2024
until post-Breathe era becomes a reality.

Ref: nrfconnect#17251

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull gmarull requested review from a team as code owners September 25, 2024 13:30
@NordicBuilder NordicBuilder removed the DNM label Sep 25, 2024
bjarki-andreasen pushed a commit to bjarki-andreasen/sdk-nrf that referenced this pull request Sep 25, 2024
until post-Breathe era becomes a reality.

Ref: nrfconnect#17251

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull gmarull added the CI-disable Disable CI for this PR label Sep 25, 2024
`void` functions do not return anything, so they can't have Doxygen
documentation.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
This is required to render Doxygen content in the same Sphinx output
folder, as Doxygen is run first.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
So that further Sphinx+Doxygen docsets are easy to add.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
Native Doxygen content will be served, and Sphinx will link to it.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
It's no longer required as we're not using breathe anymore.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
Breathe will no longer be used.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
It is no longer needed after breathe removal.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
We are now serving Doxygen content, so let's drop the redundant Sphinx
"shim".

Signed-off-by: Gerard Marull-Paretas <[email protected]>
So we can finally _breathe_.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@github-actions github-actions bot removed the manifest label Sep 26, 2024
@gmarull gmarull merged commit d099b86 into nrfconnect:main Sep 26, 2024
13 checks passed
@gmarull gmarull deleted the drop-all-breathe branch September 26, 2024 08:23
bjarki-andreasen pushed a commit to bjarki-andreasen/sdk-nrf that referenced this pull request Sep 26, 2024
until post-Breathe era becomes a reality.

Ref: nrfconnect#17251

Signed-off-by: Gerard Marull-Paretas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval. manifest-nrfxlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants