wifi: Fixes for RC1 issues #17653

krish2718 · 2024-10-05T18:57:58Z

The driver still resides in Zephyr upstream, but docs are only in NCS as Zephyr doesn't have vedor docs.

Fix options-from-kconfig extensions to take a custom path @gmarull
Add external_context extensions to pull in RST + Doxygen docs from modules/hal/nordic/drivers/nrf_wifi/doc @gmarull

NordicBuilder · 2024-10-05T18:58:56Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 20

Inputs:

Sources:

sdk-nrf: PR head: dff52939484af343f551659eff0c20e41ca22fd5
nrfxlib: PR head: 7dbaa1c26233af138b2f02f7e56fe7c98ba48269
zephyr: PR head: c8fd566676f5205165304243f4313469d01d9e65

more details

sdk-nrf:

PR head: dff52939484af343f551659eff0c20e41ca22fd5
merge base: 19c0f9c249d0e53b50b188596133f207b68ff0d2
target head (main): 19c0f9c249d0e53b50b188596133f207b68ff0d2
Diff

nrfxlib:

PR head: 7dbaa1c26233af138b2f02f7e56fe7c98ba48269
merge base: 1e25b050dc4cfc767ced5f75174460d67b19b688
Diff

zephyr:

PR head: c8fd566676f5205165304243f4313469d01d9e65
merge base: 08f1c5bc9f202932467d1ba8c0398c8093d29fa4
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (28)

CODEOWNERS
doc
│  ├── CMakeLists.txt
│  ├── nrf
│  │  ├── drivers
│  │  │  ├── wifi.rst
│  │  │  ├── wifi
│  │  │  │  ├── nrf70_native.rst
│  │  │  │  │ nrf70_portable.rst
│  ├── nrfxlib
│  │  │ nrfxlib.doxyfile.in
│  ├── wifi
│  │  │ wifi.doxyfile.in
dts
│  ├── bindings
│  │  ├── radio_coex
│  │  │  │ nordic,nrf700x-coex.yaml
nrfxlib
│  ├── CODEOWNERS
│  ├── nrf_wifi
│  │  ├── bin
│  │  │  ├── ncs
│  │  │  │  ├── default
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── offloaded_raw_tx
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── radio_test
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── scan_only
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── system_with_raw
│  │  │  │  │  │ nrf70.bin
snippets
│  ├── nrf70-driver-debug
│  │  │ overlay-nrf70-driver-debug.conf
subsys
│  ├── mpsl
│  │  ├── cx
│  │  │  │ Kconfig
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf7002dk
│  │  │  │  │ nrf7002dk_nrf5340_cpunet.dts
│  │  ├── shields
│  │  │  ├── nrf7002eb
│  │  │  │  ├── nrf7002eb.overlay
│  │  │  │  │ nrf7002eb_coex.overlay
│  │  │  ├── nrf7002ek
│  │  │  │  │ nrf7002ek_coex.overlay
│  ├── drivers
│  │  ├── wifi
│  │  │  ├── nrfwifi
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── off_raw_tx
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ off_raw_tx_api.c
│  │  │  │  ├── src
│  │  │  │  │  │ net_if.c
│  ├── subsys
│  │  ├── net
│  │  │  ├── lib
│  │  │  │  ├── capture
│  │  │  │  │  │ capture.c
│  ├── tests
│  │  ├── drivers
│  │  │  ├── can
│  │  │  │  ├── api
│  │  │  │  │  ├── src
│  │  │  │  │  │  ├── canfd.c
│  │  │  │  │  │  │ classic.c
│  │ west.yml

Outputs:

Toolchain

Version: b44b7a08c9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b44b7a08c9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 1235
- sdk-zephyr test count: 7200
❌ Integration tests
- ❌ test_ble_nrf_config
- ❌ test-fw-nrfconnect-ble_samples
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ✅ test-fw-nrfconnect-nrf-iot_cloud
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ❌ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-thread
- ✅ test-fw-nrfconnect-zigbee
- ✅ test-sdk-find-my
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-fw-nrfconnect-nrf-iot_positioning
- ✅ test-sdk-wifi
- ✅ test-low-level

Disabled integration tests

- desktop52_verification
- doc-internal
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-tfm
- test-sdk-audio
- test-sdk-dfu
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk

Note: This message is automatically posted and updated by the CI

krish2718 · 2024-10-05T19:17:40Z

Doc failure is due to Task1 not being complete.

gmarull · 2024-10-07T08:51:35Z

The driver still resides in Zephyr upstream, but docs are only in NCS as Zephyr doesn't have vedor docs.

Fix options-from-kconfig extensions to take a custom path @gmarull

Add external_context extensions to pull in RST + Doxygen docs from modules/hal/nordic/drivers/nrf_wifi/doc @gmarull

For external_content simply extend doc/nrf/conf.py paths, and for Doxygen the same in doc/nrf/nrf.doxyfile.in.

krish2718 · 2024-10-07T10:17:31Z

The driver still resides in Zephyr upstream, but docs are only in NCS as Zephyr doesn't have vedor docs.

Fix options-from-kconfig extensions to take a custom path @gmarull

Add external_context extensions to pull in RST + Doxygen docs from modules/hal/nordic/drivers/nrf_wifi/doc @gmarull

For external_content simply extend doc/nrf/conf.py paths, and for Doxygen the same in doc/nrf/nrf.doxyfile.in.

The nrfx (hal_nordic) docset from the utils has been removed https://github.com/nrfconnect/sdk-nrf/blame/main/doc/_utils/utils.py#L22 should I bring it back or just hardcode the path HAL_NORDIC_BASE?

doc/nrf/drivers/wifi/native/nrf70.rst

richabp

I think it requires an additional Wi-Fi driver top page, with the following subpages-

nRF Wi-Fi driver
nRF Wi-Fi portable driver

doc/nrf/drivers/wifi/native/nrf70.rst

doc/nrf/drivers/wifi/portable/nrf70.rst

richabp · 2024-10-17T10:54:35Z

Please remove the third bullet about the driver documentation form the "Removed" section of "Documentation" from the Changelog https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/releases_and_maturity/releases/release-notes-changelog.html#documentation.

NordicBuilder · 2024-10-24T18:59:26Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

krish2718 · 2024-10-24T21:16:43Z

I think it requires an additional Wi-Fi driver top page, with the following subpages-

nRF Wi-Fi driver

nRF Wi-Fi portable driver

we already have it https://developer.nordicsemi.com/nRF_Connect_SDK_dev/doc/PR-17653/nrf/drivers/wifi.html

PerMac

does this resolve any issue from the quarantine https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/quarantine.yaml? If so, please also remove such entries from quarantine within this PR so we can let the CI verify the fixes. If not relevant, just ignore my comment and dismiss my request

krish2718 · 2024-10-29T13:57:21Z

does this resolve any issue from the quarantine https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/quarantine.yaml? If so, please also remove such entries from quarantine within this PR so we can let the CI verify the fixes. If not relevant, just ignore my comment and dismiss my request

As commented #18241 (review) un-quarantine will be part of that PR.

As requested, unquarantine will happen in the other PR

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

CODEOWNERS

rlubos

Please update SHAs

west.yml

Top-level wifi page. Signed-off-by: Gerard Marull-Paretas <[email protected]>

This was removed during switch to nRF70, now its being re-instate as the doc would still be part of NCS docs, but with slight changes to use sources from Zephyr upstream. Signed-off-by: Chaitanya Tata <[email protected]>

These docs are primarily for low-level API. Signed-off-by: Chaitanya Tata <[email protected]>

[SHEL-3149] Correct power ceiling description in nrf70 driver documentation. Signed-off-by: Prasun Sinha <[email protected]>

This patch adds a new Doxygen docset for the Wifi APIs. Signed-off-by: Gerard Marull-Paretas <[email protected]>

These are now re-instated. Signed-off-by: Chaitanya Tata <[email protected]>

These files are now in hal_nordic. Signed-off-by: Chaitanya Tata <[email protected]>

When debugging driver we don't need WPA supplicant logs. Signed-off-by: Chaitanya Tata <[email protected]>

Handle the rename when nRF70 moved upstream Zephyr. Signed-off-by: Chaitanya Tata <[email protected]>

These are now part of upstream Zephyr. Signed-off-by: Chaitanya Tata <[email protected]>

Fixes co-ex label name to match MPSL requirements. Signed-off-by: Chaitanya Tata <[email protected]>

Latest Wi-Fi FW blobs. Signed-off-by: Chaitanya Tata <[email protected]>

rlubos · 2024-10-30T11:23:26Z

@nrfconnect/ncs-co-drivers @nrfconnect/ncs-co-build-system Please review

krish2718 requested review from bama-nordic, gmarull, richabp and sachinthegreen October 5, 2024 18:57

github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 5, 2024

krish2718 added this to the 2.8.0 milestone Oct 5, 2024

sachinthegreen approved these changes Oct 7, 2024

View reviewed changes

krish2718 mentioned this pull request Oct 12, 2024

wifi: Fix nRF70 FW blobs strategy #17858

Merged

bama-nordic reviewed Oct 17, 2024

View reviewed changes

doc/nrf/drivers/wifi/native/nrf70.rst Outdated Show resolved Hide resolved

bama-nordic reviewed Oct 17, 2024

View reviewed changes

doc/nrf/drivers/wifi/native/nrf70.rst Outdated Show resolved Hide resolved

richabp requested changes Oct 17, 2024

View reviewed changes

prsi98 force-pushed the wifi_doc_reorg branch 3 times, most recently from 18d03ec to 2b253ad Compare October 17, 2024 12:20

krish2718 force-pushed the wifi_doc_reorg branch from 2b253ad to babf503 Compare October 24, 2024 10:09

gmarull force-pushed the wifi_doc_reorg branch from babf503 to a795489 Compare October 24, 2024 18:42

krish2718 marked this pull request as ready for review October 24, 2024 20:48

krish2718 requested review from a team as code owners October 24, 2024 20:48

krish2718 force-pushed the wifi_doc_reorg branch from a795489 to 9cd562a Compare October 24, 2024 21:15

krish2718 requested a review from a team as a code owner October 24, 2024 21:15

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 24, 2024

rlubos mentioned this pull request Oct 29, 2024

manifest: sdk-zephyr: wifi: Pull fixes for RC2 #18293

Closed

srkanordic approved these changes Oct 29, 2024

View reviewed changes

krish2718 mentioned this pull request Oct 29, 2024

location + Wi-Fi: Remove tests from Quarantine #18241

Merged

richabp approved these changes Oct 29, 2024

View reviewed changes

PerMac previously requested changes Oct 29, 2024

View reviewed changes

krish2718 removed the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Oct 29, 2024

divipillai reviewed Oct 29, 2024

View reviewed changes

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved

umapraseeda reviewed Oct 30, 2024

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

rlubos reviewed Oct 30, 2024

View reviewed changes

west.yml Outdated Show resolved Hide resolved

gmarull and others added 10 commits October 30, 2024 16:45

doc: nrf: drivers: add top-level wifi page

db8e24c

Top-level wifi page. Signed-off-by: Gerard Marull-Paretas <[email protected]>

doc: nrf: Add nRF70 drivers doc

0773f58

This was removed during switch to nRF70, now its being re-instate as the doc would still be part of NCS docs, but with slight changes to use sources from Zephyr upstream. Signed-off-by: Chaitanya Tata <[email protected]>

doc: nrf: Add portable nRF70 docs

757ba9e

These docs are primarily for low-level API. Signed-off-by: Chaitanya Tata <[email protected]>

doc: nrf: drivers: Add correction for power ceiling

a0f027b

[SHEL-3149] Correct power ceiling description in nrf70 driver documentation. Signed-off-by: Prasun Sinha <[email protected]>

doc: add doxygen wifi docset

ec40ac8

This patch adds a new Doxygen docset for the Wifi APIs. Signed-off-by: Gerard Marull-Paretas <[email protected]>

codeowners: Add entries for Wi-Fi driver docs

bf1233a

These are now re-instated. Signed-off-by: Chaitanya Tata <[email protected]>

doc: nrfxlib: Remove nRF70 driver files

5534373

These files are now in hal_nordic. Signed-off-by: Chaitanya Tata <[email protected]>

snippets: nrf70-driver-debug: Remove WPA supplicant debug logging

529f5bb

When debugging driver we don't need WPA supplicant logs. Signed-off-by: Chaitanya Tata <[email protected]>

mpsl: cx: Fix nRF70 SR co-existence

b19d606

Handle the rename when nRF70 moved upstream Zephyr. Signed-off-by: Chaitanya Tata <[email protected]>

dts: bindings: Remove leftover nRF70 co-ex bindings

3e3e5fc

These are now part of upstream Zephyr. Signed-off-by: Chaitanya Tata <[email protected]>

krish2718 force-pushed the wifi_doc_reorg branch from bc2b0e5 to dff5293 Compare October 30, 2024 11:20

krish2718 added 2 commits October 30, 2024 16:50

mainfest: sdk-zephyr: Pull fix for co-ex label

1bd2ffe

Fixes co-ex label name to match MPSL requirements. Signed-off-by: Chaitanya Tata <[email protected]>

manifest: sdk-nrfxlib: Pull update Wi-Fi FW blobs

dff5293

Latest Wi-Fi FW blobs. Signed-off-by: Chaitanya Tata <[email protected]>

NordicBuilder removed the DNM label Oct 30, 2024

rlubos approved these changes Oct 30, 2024

View reviewed changes

nordicjm approved these changes Oct 30, 2024

View reviewed changes

anangl approved these changes Oct 30, 2024

View reviewed changes

rlubos merged commit 5591db1 into nrfconnect:main Oct 30, 2024
12 of 14 checks passed

wifi: Fixes for RC1 issues #17653

wifi: Fixes for RC1 issues #17653

Uh oh!

Conversation

krish2718 commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

krish2718 commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmarull commented Oct 7, 2024

Uh oh!

krish2718 commented Oct 7, 2024

Uh oh!

Uh oh!

Uh oh!

richabp left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

richabp commented Oct 17, 2024

Uh oh!

NordicBuilder commented Oct 24, 2024

Uh oh!

krish2718 commented Oct 24, 2024

Uh oh!

PerMac left a comment

Choose a reason for hiding this comment

Uh oh!

krish2718 commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rlubos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rlubos commented Oct 30, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

krish2718 commented Oct 5, 2024 •

edited

Loading

NordicBuilder commented Oct 5, 2024 •

edited

Loading

krish2718 commented Oct 5, 2024 •

edited

Loading

richabp left a comment •

edited

Loading

krish2718 commented Oct 29, 2024 •

edited

Loading