-
Notifications
You must be signed in to change notification settings - Fork 1.4k
nrf_security: Refactor builtin key handling #17973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: dd3a5f855346ab4e3ce5805712d44a0130ad2648 more detailssdk-nrf:
Github labels
List of changed files detected by CI (7)Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
tomi-font
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits in the commit message:
This updates the way
thatwe handle the configuration
same logic as all the other PSA Crypto core configurations.
This is a promptless option so no need to update any sample/application
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
cc4ccee to
813d61d
Compare
This updates the way we handle the configuration MBEDTLS_PSA_CRYPTO_BUILTIN_KEYS so that it follows the same logic as all the other PSA Crypto core configurations. Also does minor cleanups for this option. It also renames the configuration option MBEDTLS_ENABLE_BUILTIN_KEYS->MBEDTLS_PSA_CRYPTO_BUILTIN_KEYS. This is a promptless option so no need to update any sample/application because of this. Ref: NCSDK-29543 Signed-off-by: Georgios Vasilakis <[email protected]> Update subsys/nrf_security/Kconfig Co-authored-by: Tomi Fontanilles <[email protected]>
Licence was BSD which is not correct in the external_core.cmake file. Signed-off-by: Georgios Vasilakis <[email protected]>
Enable the builtin keys for the nRF54L series when nrf_security is being used. This option for builtin keys is needed for the KMU keys which don't always have dependencies on the hardware unique key or the identity key. We guard this option on the PSA Cracen driver because the driver implements the necessary builtin key functions. Signed-off-by: Georgios Vasilakis <[email protected]>
frkv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nvlsianpu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for Dominik's provisioning sample and allow testing nrfconnect/sdk-mcuboot#335 successfully.
This updates the way that we handle the configuration MBEDTLS_PSA_CRYPTO_BUILTIN_KEYS so that it follows the same logic as all the other PSA core configurations. Also does minor cleanups for this option.
It also renames the configuration option
MBEDTLS_ENABLE_BUILTIN_KEYS->MBEDTLS_PSA_CRYPTO_BUILTIN_KEYS.
This is a promptless option so need to update any sample/application because of this.
Ref: NCSDK-29543