Skip to content

Conversation

@NordicBuilder
Copy link
Contributor

Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#2143

@NordicBuilder NordicBuilder requested a review from a team as a code owner October 22, 2024 07:02
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 22, 2024
@NordicBuilder
Copy link
Contributor Author

NordicBuilder commented Oct 22, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@e96a443 nrfconnect/sdk-nrfxlib@91a10d8 nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@3d0bbe4 nrfconnect/sdk-zephyr@89bad3f (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor Author

NordicBuilder commented Oct 22, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 44

Inputs:

Sources:

sdk-nrf: PR head: 16e40291b9e3f9d71cd6cb753c7224a1fe524c0a
nrfxlib: PR head: 91a10d8174dd6ef798d14badae716f66895c5f23
zephyr: PR head: 89bad3f2d60239a2e3503d7d79e4f92eeba0a5ba

more details

sdk-nrf:

PR head: 16e40291b9e3f9d71cd6cb753c7224a1fe524c0a
merge base: c01d9380ddf82e8204098b3b08a7f423d5db292c
target head (main): c01d9380ddf82e8204098b3b08a7f423d5db292c
Diff

nrfxlib:

PR head: 91a10d8174dd6ef798d14badae716f66895c5f23
merge base: e96a443bcdb6d3a4f5c83ee81221dba904b1b1fa
Diff

zephyr:

PR head: 89bad3f2d60239a2e3503d7d79e4f92eeba0a5ba
merge base: 3d0bbe4b8ddbbb4645f5b7178afe5ad24864ae22
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (49)
applications
│  ├── nrf5340_audio
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  │ audio_sync_timer.c
nrfxlib
│  ├── softdevice_controller
│  │  │ CMakeLists.txt
samples
│  ├── bluetooth
│  │  ├── conn_time_sync
│  │  │  ├── boards
│  │  │  │  ├── nrf5340_audio_dk_nrf5340_cpuapp.conf
│  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  ├── direct_test_mode
│  │  │  ├── boards
│  │  │  │  ├── nrf5340dk_nrf5340_cpunet.conf
│  │  │  │  ├── nrf5340dk_nrf5340_cpunet_hci.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  ├── iso_time_sync
│  │  │  ├── boards
│  │  │  │  ├── nrf5340_audio_dk_nrf5340_cpuapp.conf
│  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  ├── peripheral
│  │  ├── 802154_phy_test
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  ├── radio_test
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
subsys
│  ├── debug
│  │  ├── cpu_load
│  │  │  │ cpu_load.c
│  │  ├── ppi_trace
│  │  │  │ ppi_trace.c
│  ├── dm
│  │  │ dm.c
│  ├── esb
│  │  │ esb_dppi.c
│  ├── mpsl
│  │  ├── fem
│  │  │  ├── common
│  │  │  │  │ mpsl_fem_utils.c
│  │  ├── pin_debug
│  │  │  │ mpsl_pin_debug_radio_core.c
tests
│  ├── subsys
│  │  ├── debug
│  │  │  ├── cpu_load
│  │  │  │  ├── src
│  │  │  │  │  │ test_cpu_load.c
west.yml
zephyr
│  ├── drivers
│  │  ├── counter
│  │  │  │ counter_nrfx_rtc.c
│  │  ├── pwm
│  │  │  │ Kconfig.nrf_sw
│  │  ├── serial
│  │  │  │ Kconfig.nrfx_uart_instance
│  ├── dts
│  │  ├── arm
│  │  │  ├── nordic
│  │  │  │  ├── nrf5340_cpuapp_peripherals.dtsi
│  │  │  │  ├── nrf5340_cpunet.dtsi
│  │  │  │  │ nrf91_peripherals.dtsi
│  │  ├── bindings
│  │  │  ├── misc
│  │  │  │  │ nordic,nrf-ppib.yaml
│  │  ├── common
│  │  │  ├── nordic
│  │  │  │  ├── nrf54l15.dtsi
│  │  │  │  │ nrf54l20.dtsi
│  ├── modules
│  │  ├── hal_nordic
│  │  │  ├── nrfx
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.logging
│  │  │  │  ├── nrfe_config.h
│  │  │  │  ├── nrfx_config.h
│  │  │  │  ├── nrfx_config_common.h
│  │  │  │  ├── nrfx_config_reserved_resources.h
│  │  │  │  ├── nrfx_config_reserved_resources_ncs.h
│  │  │  │  │ nrfx_glue.h
│  ├── samples
│  │  ├── boards
│  │  │  ├── nordic
│  │  │  │  ├── nrfx
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  │ prj.conf
│  ├── soc
│  │  ├── nordic
│  │  │  ├── nrf53
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.sync_rtc
│  │  │  │  │ sync_rtc.c
│  │ west.yml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-sdk-audio
    • ◻️ test_ble_nrf_config
    • ◻️ test-fw-nrfconnect-ble_samples
    • ◻️ test-fw-nrfconnect-chip
    • ◻️ test-fw-nrfconnect-nfc
    • ◻️ test-fw-nrfconnect-nrf-iot_thingy91
    • ◻️ test-fw-nrfconnect-nrf_crypto
    • ◻️ test-fw-nrfconnect-rpc
    • ◻️ test-fw-nrfconnect-rs
    • ◻️ test-fw-nrfconnect-fem
    • ◻️ test-fw-nrfconnect-tfm
    • ◻️ test-fw-nrfconnect-thread
    • ◻️ test-fw-nrfconnect-zigbee
    • ◻️ test-sdk-find-my
    • ◻️ test-fw-nrfconnect-nrf-iot_mosh
    • ◻️ test-sdk-sidewalk
    • ◻️ test-low-level
    • ◻️ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-proprietary_esb
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-ps
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from 98efc5f to 70653fa Compare October 22, 2024 07:08
@e-rk e-rk requested review from a team, ankuns, lemrey, martintv and nordic-krch as code owners October 22, 2024 07:08
@e-rk e-rk requested review from alexsven, gWacey, koffes and rick1082 and removed request for a team October 22, 2024 07:08
@e-rk e-rk added this to the 2.8.0 milestone Oct 22, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to enable all of the DPPIC's and PPIB's here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having all PPIB and DPPICs enabled, the nrfx_gppi_dppi_ppib_lumos.c won't build unfortunately. Maybe there could be a separate CONFIG_NRFX_GPPI config that automatically enables those instances on Lumos.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, then we should either use a separate CONFIG_NRFX_GPPI, or add a followup task to remove the ones that are not needed. The commit message should explain the reasoning behind adding all these

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the CONFIG_NRFX_GPPI config and used it instead.

@NordicBuilder
Copy link
Contributor Author

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from 70653fa to 2889c7e Compare October 22, 2024 22:40
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from d3b3e83 to b7a79c7 Compare October 23, 2024 07:00
@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from b7a79c7 to 9847e56 Compare October 23, 2024 11:35
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 9847e56 to e0650b2 Compare October 23, 2024 11:35
@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from 05d3dfb to 03aae38 Compare November 12, 2024 09:25
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 03aae38 to 002d9b9 Compare November 12, 2024 09:27
@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from 002d9b9 to 2b97e06 Compare November 12, 2024 10:00
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 2b97e06 to 7821032 Compare November 18, 2024 09:26
@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from 7821032 to ba1b2aa Compare November 18, 2024 09:27
@NordicBuilder
Copy link
Contributor Author

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch 2 times, most recently from a6c63c4 to e1e6ce2 Compare November 18, 2024 14:54
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch 2 times, most recently from aba8de3 to fe40c1b Compare November 19, 2024 15:38
@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from fe40c1b to 50d0f59 Compare November 19, 2024 15:39
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 50d0f59 to 089d981 Compare November 19, 2024 15:40
@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from 089d981 to 823c51f Compare November 19, 2024 15:45
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 823c51f to 3c2d2f5 Compare November 19, 2024 16:08
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 3c2d2f5 to bfbb376 Compare November 20, 2024 08:12
@e-rk e-rk force-pushed the auto-manifest-sdk-zephyr-2143 branch from bfbb376 to 872e79f Compare November 20, 2024 11:32
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 872e79f to 81cc4e0 Compare November 20, 2024 11:42
Updated the hal_nordic revision and adjusted the code base to use
multi-instance DPPI API.
Certain applications have to explicitly enable nrfx_dppi and nrfx_ppib
support with Kconfigs.
Updated the nrfxlib revision to add the softdevice_controller include
paths globally.

Signed-off-by: Rafał Kuźnia <[email protected]>
@NordicBuilder NordicBuilder force-pushed the auto-manifest-sdk-zephyr-2143 branch from 81cc4e0 to 16e4029 Compare November 20, 2024 15:20
@NordicBuilder NordicBuilder removed the DNM label Nov 20, 2024
@rlubos
Copy link
Contributor

rlubos commented Nov 20, 2024

@lemrey @nordic-krch @nrfconnect/ncs-audio @nrfconnect/ncs-si-muffin Please review

@rlubos
Copy link
Contributor

rlubos commented Nov 21, 2024

This is blocking other nrfxlib integrations, merging as is...

@rlubos rlubos merged commit 333818a into nrfconnect:main Nov 21, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-nrfxlib manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants